Gradle Changes to Build Repo with newest Android Studio #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…est Android Studio Laughing Ladybug
grote
reviewed
Nov 21, 2024
| @@ -7,6 +7,7 @@ | |||
| /.idea/workspace.xml | |||
| /.idea/navEditor.xml | |||
| /.idea/assetWizardSettings.xml | |||
| /.idea/runConfigurations.xml | |||
There was a problem hiding this comment.
Why did you add this? I think we want to be able to use VCS shared run configurations.
grote
reviewed
Nov 21, 2024
| zipStoreBase=GRADLE_USER_HOME | ||
| distributionUrl=https\://services.gradle.org/distributions/gradle-7.5-all.zip | ||
| distributionSha256Sum=97a52d145762adc241bad7fd18289bf7f6801e08ece6badf80402fe2b9f250b1 |
There was a problem hiding this comment.
Don't we need to update the hash instead of removing it?
| @@ -1,7 +1,7 @@ | |||
| #!/usr/bin/env sh | |||
| #!/bin/sh | |||
There was a problem hiding this comment.
Not sure we should update the scripts here as this is a security risk and rarely necessary. We do have a github action to verify the files, so maybe it is fine, but then we should use the latest version: https://github.com/onionshare/onionshare-android/blob/main/.github/workflows/build.yml#L13
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The gradle wrapper used by the project will not work with the latest IDE. I bumped it to 8.9 using Android Studio Wizards, and ignored a
.idea/file that was generated and not tracked by.gitignore