Skip to content
This repository was archived by the owner on Apr 1, 2020. It is now read-only.

[Proposal] Base config command line argument for #2022 #2091

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bryphe
Copy link
Member

@bryphe bryphe commented Apr 14, 2018

This adds a command line parameter to specify / override Oni's base configuration. This lets you supply a configuration file that acts as a new set of defaults. So the order of precedence would be:

Oni defaults -> base config defaults -> user configuration -> workspace configuration

This happens implicitly, as it is based on the order of 'adding' configuration files. For this parameter, we're adding the base config prior to adding the user config on app startup.

This parameter can be used like:

oni --base-config="/config.test.js"

@badosu - does this help you with #2022 ? Would you be able to leverage this?

If it is easier, we could also specify this via an environment variable, like ONI_BASE_CONFIG_PATH.

@badosu
Copy link
Collaborator

badosu commented Apr 14, 2018

With this approach I would distribute an oni binary that is a wrapper for oni --base-config=.... That makes it cumbersome for the user to customize it the way it wants.

Do you think we can have something like:

// config.ts

import './minimal-config'
// import './default-config'

I am not familiar with typescript so maybe this is already feasible? This way the user can edit his config file to not import any setting or to use oni's defaults.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants