This repository was archived by the owner on Apr 1, 2020. It is now read-only.
[Proposal] Base config command line argument for #2022 #2091
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a command line parameter to specify / override Oni's base configuration. This lets you supply a configuration file that acts as a new set of defaults. So the order of precedence would be:
Oni defaults -> base config defaults -> user configuration -> workspace configuration
This happens implicitly, as it is based on the order of 'adding' configuration files. For this parameter, we're adding the base config prior to adding the user config on app startup.
This parameter can be used like:
@badosu - does this help you with #2022 ? Would you be able to leverage this?
If it is easier, we could also specify this via an environment variable, like
ONI_BASE_CONFIG_PATH
.