Updated game sound logic for case when game ends in a Tie #2958 #183
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2791
Proposed Changes
-Add a case when game ends in a tie (returns
0
instead of a player number)-updates
winner
interface prop withtie
as an optionConcerns
winner
interface prop be number or string? Where would it be set to be a string? I only saw numbers returned (for player id) but not sure when a string is set.