Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated game sound logic for case when game ends in a Tie #2958 #183

Merged
merged 5 commits into from
Feb 16, 2025

Conversation

mister-dl
Copy link
Contributor

Fixes #2791

Proposed Changes

-Add a case when game ends in a tie (returns 0 instead of a player number)
-updates winner interface prop with tie as an option

Concerns

  • should winner interface prop be number or string? Where would it be set to be a string? I only saw numbers returned (for player id) but not sure when a string is set.
  • I didn't see any jest tests for this. If we don't need it its fine, just want to make sure i'm not missing it somewhere.

@anoek
Copy link
Member

anoek commented Feb 16, 2025

Thanks for the fix! I don't think there were any tests for this to begin with, tests are certainly welcome though.

@anoek anoek merged commit fa1e17c into online-go:main Feb 16, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants