Merge pull request #2 from onmoon/add-typed-props

Added typed properties
onmoon · Mar 5, 2020 · 5c57763 · 5c57763
2 parents e8ef3eb + ee6cf1d
commit 5c57763
Show file tree

Hide file tree

Showing 5 changed files with 7 additions and 14 deletions.
diff --git a/.travis.yml b/.travis.yml
@@ -7,8 +7,6 @@ cache:
     - $HOME/.composer/cache
 
 php:
-  - 7.2
-  - 7.3
   - 7.4
   - nightly
 
@@ -36,9 +34,9 @@ jobs:
       script: ./vendor/bin/security-checker security:check
 
     - stage: Code Style
-      php: 7.3
+      php: 7.4
       script:
         - composer show squizlabs/php_codesniffer
         - composer show doctrine/coding-standard
         - composer show slevomat/coding-standard
-        - ./vendor/bin/phpcs
+        - ./vendor/bin/phpcs
diff --git a/composer.json b/composer.json
@@ -18,7 +18,7 @@
         }
     ],
     "require": {
-        "php": "^7.2",
+        "php": "^7.4",
         "ext-bcmath": "*",
         "doctrine/dbal": "^2.10",
         "moneyphp/money": "^3.3",

diff --git a/src/BaseMoney.php b/src/BaseMoney.php
@@ -25,11 +25,8 @@ abstract class BaseMoney
 {
     private const HUMAN_READABLE_NAME = 'Money';
 
-    /** @var string */
-    protected $amount;
-
-    /** @var string */
-    protected $currency;
+    protected string $amount;
+    protected string $currency;
 
     final private function __construct(string $amount, string $currency)
     {

diff --git a/src/Currency.php b/src/Currency.php
@@ -9,8 +9,7 @@
 
 class Currency
 {
-    /** @var string */
-    private $code;
+    private string $code;
 
     final private function __construct(string $code)
     {

diff --git a/src/Money.php b/src/Money.php
@@ -11,8 +11,7 @@
 
 class Money extends BaseMoney
 {
-    /** @var Currencies|null */
-    private static $currencies = null;
+    private static ?Currencies $currencies = null;
 
     protected static function classSubunits() : int
     {