Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump onnx.Cast to opset 21 , adding int/uint4 support #3057

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

jorickert
Copy link
Collaborator

@jorickert jorickert commented Jan 30, 2025

This adds support to cast to and from int4/uint4

@jorickert jorickert marked this pull request as draft January 30, 2025 15:11
@jorickert jorickert marked this pull request as ready for review January 30, 2025 16:10
@jorickert jorickert changed the title Upgrade onnx.Cast to opset 21 Bump onnx.Cast to opset 21 Jan 30, 2025
Copy link
Collaborator

@tungld tungld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for adding support for I4/UI4!

@jorickert
Copy link
Collaborator Author

I will wait with merging this until the discussion in #3059 is resolved

@jorickert jorickert changed the title Bump onnx.Cast to opset 21 Bump onnx.Cast to opset 21 , adding int/uint4 support Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants