Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend GridSample support #3060

Merged
merged 5 commits into from
Feb 3, 2025
Merged

Conversation

jorickert
Copy link
Collaborator

  • Adds shape inference
  • Adds a verifier
  • Adds Opset 22 support
  • Adds a conversion patter to convert Opset 16 -> 22

ttjost and others added 3 commits January 30, 2025 11:03
Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com>
Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com>
Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com>
@jorickert jorickert requested a review from tungld January 30, 2025 11:04
Copy link
Collaborator

@tungld tungld left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thank you very much for a comprehensive PR!

@tungld
Copy link
Collaborator

tungld commented Feb 3, 2025

Hi @jorickert let me know if you need me merging this PR.

@jorickert jorickert merged commit d35d593 into onnx:main Feb 3, 2025
7 checks passed
@jorickert jorickert deleted the jrickert.upstream.gridsample branch February 3, 2025 07:49
@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #16218 [push] Extend GridSample suppor... started at 02:50

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #15245 [push] Extend GridSample suppor... started at 03:09

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #16216 [push] Extend GridSample suppor... started at 01:50

@jenkins-droid
Copy link
Collaborator

Jenkins Linux amd64 Build #16216 [push] Extend GridSample suppor... passed after 1 hr 21 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux s390x Build #16218 [push] Extend GridSample suppor... passed after 1 hr 29 min

@jenkins-droid
Copy link
Collaborator

Jenkins Linux ppc64le Build #15245 [push] Extend GridSample suppor... passed after 2 hr 32 min

christopherlmunoz pushed a commit to christopherlmunoz/onnx-mlir that referenced this pull request Feb 6, 2025
* feat: add verifier and shape inference for Onnx.GridSample.

Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com>

* Support onnx.GridSampleV22

Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com>

* Check attributes in GridSample verifier

Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com>

---------

Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com>
Co-authored-by: Tiago Trevisan Jost <tiago.trevisanjost@amd.com>
jorickert added a commit to Xilinx/onnx-mlir that referenced this pull request Feb 10, 2025
* feat: add verifier and shape inference for Onnx.GridSample.

Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com>

* Support onnx.GridSampleV22

Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com>

* Check attributes in GridSample verifier

Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com>

---------

Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com>
Co-authored-by: Tiago Trevisan Jost <tiago.trevisanjost@amd.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants