-
Notifications
You must be signed in to change notification settings - Fork 337
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend GridSample support #3060
Conversation
jorickert
commented
Jan 30, 2025
- Adds shape inference
- Adds a verifier
- Adds Opset 22 support
- Adds a conversion patter to convert Opset 16 -> 22
Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com>
Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com>
Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thank you very much for a comprehensive PR!
Hi @jorickert let me know if you need me merging this PR. |
Jenkins Linux s390x Build #16218 [push] Extend GridSample suppor... started at 02:50 |
Jenkins Linux ppc64le Build #15245 [push] Extend GridSample suppor... started at 03:09 |
Jenkins Linux amd64 Build #16216 [push] Extend GridSample suppor... started at 01:50 |
Jenkins Linux amd64 Build #16216 [push] Extend GridSample suppor... passed after 1 hr 21 min |
Jenkins Linux s390x Build #16218 [push] Extend GridSample suppor... passed after 1 hr 29 min |
Jenkins Linux ppc64le Build #15245 [push] Extend GridSample suppor... passed after 2 hr 32 min |
* feat: add verifier and shape inference for Onnx.GridSample. Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com> * Support onnx.GridSampleV22 Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com> * Check attributes in GridSample verifier Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com> --------- Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com> Co-authored-by: Tiago Trevisan Jost <tiago.trevisanjost@amd.com>
* feat: add verifier and shape inference for Onnx.GridSample. Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com> * Support onnx.GridSampleV22 Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com> * Check attributes in GridSample verifier Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com> --------- Signed-off-by: Rickert, Jonas <Jonas.Rickert@amd.com> Co-authored-by: Tiago Trevisan Jost <tiago.trevisanjost@amd.com>