Add sign to idempotent ops list #139
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ananyamukh6
force-pushed
the
idempotent_sign
branch
from
8086dfe
to
7032cc7
Compare
|
LGTM, thanks! |
|
@daquexian , the tests seemsed to have failed because of flake8. I pused a patch fixing the flake8 errors. Is there any other style checks to be run (like say for the cpp code)? |
Signed-off-by: Ananya <[email protected]>
Signed-off-by: Ananya <[email protected]>
ananyamukh6
force-pushed
the
idempotent_sign
branch
from
2c21301
to
d674903
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sign op is idempotent, so adding it to eliminate_consecutive_idempotent_ops pass