Allow tools to display percent progress in the monitor #258
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ramkrishna2910
approved these changes
Jan 6, 2025
apsonawane
pushed a commit
to apsonawane/turnkeyml-cuda
that referenced
this pull request
Jan 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The TKML progress monitor can now show a % progress for each tool, if that tool provides it via a new Tool.set_percent_progress(percent: float) API.
Tools that do not use this API will look like they always have (this feature is totally optional).
This PR adds the new API and demonstrates how to use it in the example plugin. Future PRs will add progress indicators to some of the Tools.
Example Demo
progress.indicator.Recording.mp4
MMLU Demo
Note: this feature will be added in a future PR.
mmlu.progress.mp4