Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor changes fixing onnxruntime_genai issue and input_path #267

Merged
merged 2 commits into from
Jan 15, 2025

Conversation

apsonawane
Copy link
Contributor

This PR adds a fix to a breaking change which is going to be released in 0.6.0 version included in this PR:
microsoft/onnxruntime-genai@7c0f0d1

Now we can be able to pass local huggingface checkpoint path if the model is not present on huggingface (This is helpful for unreleased model and local testing)

@apsonawane
Copy link
Contributor Author

Forgot to run linter. Will update the PR

@jeremyfowers
Copy link
Collaborator

Thanks for this PR! We had some issues with our CI that we just fixed in main and updated to your branch. Testing should work better now.

Copy link
Collaborator

@jeremyfowers jeremyfowers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me! I pulled the branch and ran locally and it worked for me. Thanks very much for proactively addressing the breaking change.

@ramkrishna2910 ramkrishna2910 merged commit c107c2a into onnx:main Jan 15, 2025
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants