Tile stats #1339
Triggered via pull request
September 16, 2023 20:45
msbarry
Status
Success
Total duration
7m 30s
Artifacts
–
This run and associated checks have been archived and are scheduled for deletion.
Learn more about checks retention
sonar.yml
on: pull_request
Analyze with Sonar
7m 18s
Annotations
10 warnings
|
MINOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/Planetiler.java#L94
Remove the "layerStatsPath" field and declare it as a local variable in the relevant methods.
rule: java:S1450 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1450&rule_key=java%3AS1450)
issue url: https://sonarcloud.io/project/issues?pullRequest=656&open=AYqYcGRQ_50aaKHwDaU2&id=onthegomap_planetiler
|
|
MAJOR BUG:
planetiler-core/src/main/java/com/onthegomap/planetiler/archive/TileArchiveWriter.java#L325
A "NullPointerException" could be thrown; "bytes" is nullable here.
rule: java:S2259 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS2259&rule_key=java%3AS2259)
issue url: https://sonarcloud.io/project/issues?pullRequest=656&open=AYqYcGRt_50aaKHwDaU3&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/mbtiles/Mbtiles.java#L507
Remove this call to a deprecated class, it has been marked for removal.
rule: java:S5738 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS5738&rule_key=java%3AS5738)
issue url: https://sonarcloud.io/project/issues?pullRequest=656&open=AYqYcGUs_50aaKHwDaU5&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/mbtiles/Mbtiles.java#L507
Remove this call to a deprecated class, it has been marked for removal.
rule: java:S5738 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS5738&rule_key=java%3AS5738)
issue url: https://sonarcloud.io/project/issues?pullRequest=656&open=AYqYcGUs_50aaKHwDaU6&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/mbtiles/Mbtiles.java#L518
Remove this call to a deprecated class, it has been marked for removal.
rule: java:S5738 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS5738&rule_key=java%3AS5738)
issue url: https://sonarcloud.io/project/issues?pullRequest=656&open=AYqYcGUs_50aaKHwDaU7&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/mbtiles/Mbtiles.java#L518
Remove this call to a deprecated class, it has been marked for removal.
rule: java:S5738 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS5738&rule_key=java%3AS5738)
issue url: https://sonarcloud.io/project/issues?pullRequest=656&open=AYqYcGUs_50aaKHwDaU8&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/mbtiles/Mbtiles.java#L542
Remove this call to a deprecated class, it has been marked for removal.
rule: java:S5738 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS5738&rule_key=java%3AS5738)
issue url: https://sonarcloud.io/project/issues?pullRequest=656&open=AYqYcGUs_50aaKHwDaU9&id=onthegomap_planetiler
|
|
MINOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/util/TileStats.java#L72
Remove the declaration of thrown exception 'java.io.IOException', as it cannot be thrown from method's body.
rule: java:S1130 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1130&rule_key=java%3AS1130)
issue url: https://sonarcloud.io/project/issues?pullRequest=656&open=AYqYcGLo_50aaKHwDaU1&id=onthegomap_planetiler
|
|
MINOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/util/TileStats.java#L318
Refactor this code to use the more specialised Functional Interface 'IntFunction<String>'
rule: java:S4276 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS4276&rule_key=java%3AS4276)
issue url: https://sonarcloud.io/project/issues?pullRequest=656&open=AYqdhujYcr0W0Z7C6wsK&id=onthegomap_planetiler
|
|
CRITICAL CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/util/TileStats.java#L445
Add a nested comment explaining why this method is empty, throw an UnsupportedOperationException or complete the implementation.
rule: java:S1186 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1186&rule_key=java%3AS1186)
issue url: https://sonarcloud.io/project/issues?pullRequest=656&open=AYqdhujYcr0W0Z7C6wsL&id=onthegomap_planetiler
|