Add experimental support for lua profiles #1522
msbarrysonar.yml
on: pull_request
Analyze with Sonar
4m 23s
Annotations
10 warnings
|
MAJOR CODE_SMELL:
planetiler-experimental/src/main/java/com/onthegomap/planetiler/experimental/lua/LuaConversions.java#L157
This class has 6 parents which is greater than 5 authorized.
rule: java:S110 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS110&rule_key=java%3AS110)
issue url: https://sonarcloud.io/project/issues?pullRequest=736&open=AYwi7KmUkLE36RnBHYi5&id=onthegomap_planetiler
|
|
MINOR CODE_SMELL:
planetiler-experimental/src/main/java/com/onthegomap/planetiler/experimental/lua/LuaConversions.java#L157
Override the "equals" method in this class.
rule: java:S2160 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS2160&rule_key=java%3AS2160)
issue url: https://sonarcloud.io/project/issues?pullRequest=736&open=AYwi7KmUkLE36RnBHYi7&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-experimental/src/main/java/com/onthegomap/planetiler/experimental/lua/LuaConversions.java#L178
This class has 6 parents which is greater than 5 authorized.
rule: java:S110 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS110&rule_key=java%3AS110)
issue url: https://sonarcloud.io/project/issues?pullRequest=736&open=AYwi7KmUkLE36RnBHYi6&id=onthegomap_planetiler
|
|
MINOR CODE_SMELL:
planetiler-experimental/src/main/java/com/onthegomap/planetiler/experimental/lua/LuaConversions.java#L178
Override the "equals" method in this class.
rule: java:S2160 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS2160&rule_key=java%3AS2160)
issue url: https://sonarcloud.io/project/issues?pullRequest=736&open=AYwi7KmUkLE36RnBHYi8&id=onthegomap_planetiler
|
|
MINOR CODE_SMELL:
planetiler-experimental/src/main/java/com/onthegomap/planetiler/experimental/lua/LuaEnvironment.java#L202
Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
rule: java:S100 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS100&rule_key=java%3AS100)
issue url: https://sonarcloud.io/project/issues?pullRequest=736&open=AYwi7KlWkLE36RnBHYiz&id=onthegomap_planetiler
|
|
MINOR CODE_SMELL:
planetiler-experimental/src/main/java/com/onthegomap/planetiler/experimental/lua/LuaEnvironment.java#L206
Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
rule: java:S100 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS100&rule_key=java%3AS100)
issue url: https://sonarcloud.io/project/issues?pullRequest=736&open=AYwi7KlWkLE36RnBHYi0&id=onthegomap_planetiler
|
|
MINOR CODE_SMELL:
planetiler-experimental/src/main/java/com/onthegomap/planetiler/experimental/lua/LuaEnvironment.java#L210
Rename this method name to match the regular expression '^[a-z][a-zA-Z0-9]*$'.
rule: java:S100 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS100&rule_key=java%3AS100)
issue url: https://sonarcloud.io/project/issues?pullRequest=736&open=AYwi7KlWkLE36RnBHYi1&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-experimental/src/main/java/com/onthegomap/planetiler/experimental/lua/LuaEnvironment.java#L242
Remove this call to a deprecated method, it has been marked for removal.
rule: java:S5738 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS5738&rule_key=java%3AS5738)
issue url: https://sonarcloud.io/project/issues?pullRequest=736&open=AYwi7KlWkLE36RnBHYi2&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-experimental/src/main/java/com/onthegomap/planetiler/experimental/lua/LuaProfile.java#L45
Return an empty collection instead of null.
rule: java:S1168 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1168&rule_key=java%3AS1168)
issue url: https://sonarcloud.io/project/issues?pullRequest=736&open=AYwi7KmMkLE36RnBHYi3&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-experimental/src/main/java/com/onthegomap/planetiler/experimental/lua/LuaProfile.java#L129
Return an empty collection instead of null.
rule: java:S1168 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1168&rule_key=java%3AS1168)
issue url: https://sonarcloud.io/project/issues?pullRequest=736&open=AYwi7KmMkLE36RnBHYi4&id=onthegomap_planetiler
|