215 deterministic ordering v2 #1585
phanecak-maptilersonar.yml
on: pull_request
Analyze with Sonar
4m 39s
Annotations
10 warnings
|
MAJOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/collection/ArraySortableFeatureMinHeap.java#L182
Return an empty array instead of null.
rule: java:S1168 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1168&rule_key=java%3AS1168)
issue url: https://sonarcloud.io/project/issues?pullRequest=382&open=AYyRBoZsEC1iAkMDztOG&id=onthegomap_planetiler
|
|
MINOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/collection/ArraySortableFeatureMinHeap.java#L230
Reduce the total number of break and continue statements in this loop to use at most one.
rule: java:S135 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS135&rule_key=java%3AS135)
issue url: https://sonarcloud.io/project/issues?pullRequest=382&open=AYyRBoZsEC1iAkMDztOF&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/collection/ArraySortableFeatureMinHeap.java#L254
This branch's code block is the same as the block for the branch on line 251.
rule: java:S1871 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1871&rule_key=java%3AS1871)
issue url: https://sonarcloud.io/project/issues?pullRequest=382&open=AYyRBoZsEC1iAkMDztOH&id=onthegomap_planetiler
|
|
MINOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/collection/SortableFeatureMerger.java#L19
Replace this type parametrization by the 'final' type `SortableFeature`.
rule: java:S4968 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS4968&rule_key=java%3AS4968)
issue url: https://sonarcloud.io/project/issues?pullRequest=382&open=AYyRBoZxEC1iAkMDztOI&id=onthegomap_planetiler
|
|
MINOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/collection/SortableFeatureMerger.java#L24
Replace this type parametrization by the 'final' type `SortableFeature`.
rule: java:S4968 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS4968&rule_key=java%3AS4968)
issue url: https://sonarcloud.io/project/issues?pullRequest=382&open=AYyRBoZxEC1iAkMDztOJ&id=onthegomap_planetiler
|
|
MINOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/collection/SortableFeatureMerger.java#L34
Replace this type parametrization by the 'final' type `SortableFeature`.
rule: java:S4968 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS4968&rule_key=java%3AS4968)
issue url: https://sonarcloud.io/project/issues?pullRequest=382&open=AYyRBoZxEC1iAkMDztOK&id=onthegomap_planetiler
|
|
MINOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/collection/SortableFeatureMerger.java#L85
Replace this type parametrization by the 'final' type `SortableFeature`.
rule: java:S4968 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS4968&rule_key=java%3AS4968)
issue url: https://sonarcloud.io/project/issues?pullRequest=382&open=AYyRBoZxEC1iAkMDztOL&id=onthegomap_planetiler
|
|
MINOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/collection/SortableFeatureMerger.java#L166
Replace this type parametrization by the 'final' type `SortableFeature`.
rule: java:S4968 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS4968&rule_key=java%3AS4968)
issue url: https://sonarcloud.io/project/issues?pullRequest=382&open=AYyRBoZxEC1iAkMDztOM&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-core/src/test/java/com/onthegomap/planetiler/collection/ArraySortableFeatureMinHeapTest.java#L59
Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception.
rule: java:S5778 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS5778&rule_key=java%3AS5778)
issue url: https://sonarcloud.io/project/issues?pullRequest=382&open=AYyRBoY8EC1iAkMDztN7&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-core/src/test/java/com/onthegomap/planetiler/collection/ArraySortableFeatureMinHeapTest.java#L60
Refactor the code of the lambda to have only one invocation possibly throwing a runtime exception.
rule: java:S5778 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS5778&rule_key=java%3AS5778)
issue url: https://sonarcloud.io/project/issues?pullRequest=382&open=AYyRBoY8EC1iAkMDztN8&id=onthegomap_planetiler
|