Add support for "files"-archive #1592
bbilgersonar.yml
on: pull_request
Analyze with Sonar
4m 37s
Annotations
5 warnings
|
MAJOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/files/WriteableFilesArchive.java#L189
Define and throw a dedicated exception instead of using a generic one.
rule: java:S112 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS112&rule_key=java%3AS112)
issue url: https://sonarcloud.io/project/issues?pullRequest=761&open=AYycoJ094X35g3GUz6so&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/files/WriteableFilesArchive.java#L234
Define and throw a dedicated exception instead of using a generic one.
rule: java:S112 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS112&rule_key=java%3AS112)
issue url: https://sonarcloud.io/project/issues?pullRequest=761&open=AYycoJ094X35g3GUz6sp&id=onthegomap_planetiler
|
|
BLOCKER BUG:
planetiler-core/src/main/java/com/onthegomap/planetiler/worker/Worker.java#L86
Use try-with-resources or close this "ExecutorService" in a "finally" clause.
rule: java:S2095 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS2095&rule_key=java%3AS2095)
issue url: https://sonarcloud.io/project/issues?pullRequest=761&open=AYycoJ1o4X35g3GUz6sr&id=onthegomap_planetiler
|
|
BLOCKER BUG:
planetiler-core/src/main/java/com/onthegomap/planetiler/worker/Worker.java#L87
Use try-with-resources or close this "ExecutorService" in a "finally" clause.
rule: java:S2095 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS2095&rule_key=java%3AS2095)
issue url: https://sonarcloud.io/project/issues?pullRequest=761&open=AYycoJ1o4X35g3GUz6sq&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/worker/Worker.java#L101
Catch Exception instead of Throwable.
rule: java:S1181 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1181&rule_key=java%3AS1181)
issue url: https://sonarcloud.io/project/issues?pullRequest=761&open=AYycoJ1o4X35g3GUz6ss&id=onthegomap_planetiler
|