Structured tag api #1867
msbarrysonar.yml
on: pull_request
Analyze with Sonar
5m 12s
Annotations
5 warnings
|
MAJOR BUG:
planetiler-core/src/main/java/com/onthegomap/planetiler/reader/JsonConversion.java#L19
Call "remove()" on "MAPPERS".
rule: java:S5164 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS5164&rule_key=java%3AS5164)
issue url: https://sonarcloud.io/project/issues?pullRequest=895&open=AY-rCz6mOttsJ0tdDP34&id=onthegomap_planetiler
|
|
CRITICAL CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/reader/Struct.java#L191
Null is returned but a "Boolean" is expected.
rule: java:S2447 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS2447&rule_key=java%3AS2447)
issue url: https://sonarcloud.io/project/issues?pullRequest=895&open=AY-rCz7JOttsJ0tdDP36&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/reader/Struct.java#L209
Return an empty array instead of null.
rule: java:S1168 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1168&rule_key=java%3AS1168)
issue url: https://sonarcloud.io/project/issues?pullRequest=895&open=AY-rCz7JOttsJ0tdDP37&id=onthegomap_planetiler
|
|
MINOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/reader/Struct.java#L346
Override the "equals" method in this class.
rule: java:S2160 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS2160&rule_key=java%3AS2160)
issue url: https://sonarcloud.io/project/issues?pullRequest=895&open=AY-rCz7JOttsJ0tdDP38&id=onthegomap_planetiler
|
|
MAJOR CODE_SMELL:
planetiler-core/src/main/java/com/onthegomap/planetiler/reader/Struct.java#L532
Merge this if statement with the enclosing one.
rule: java:S1066 (https://sonarcloud.io/organizations/onthegomap/rules?open=java%3AS1066&rule_key=java%3AS1066)
issue url: https://sonarcloud.io/project/issues?pullRequest=895&open=AY-rCz7JOttsJ0tdDP35&id=onthegomap_planetiler
|