-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add lz4 compression to planetiler #1104
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
flymarq
commented
Nov 17, 2024
- lz4 compressed files can be generated with libosmium based tools like osmium or python scripts using pyosmium like pyosmium-up-to-date
- lz4 compressed files are bigger (~15-20%) then zlib compressed files but much faster to produce and process
- this patch is in use by us for several month without any problems
- lz4 compressed files can be generated with libosmium based tools like osmium or python scripts using pyosmium like pyosmium-up-to-date - lz4 compressed files are bigger (~15-20%) then zlib compressed files but much faster to produce and process - this patch is in use by us for several month without any problems
msbarry
reviewed
Nov 17, 2024
planetiler-core/src/main/java/com/onthegomap/planetiler/reader/osm/PbfDecoder.java
Show resolved
Hide resolved
Full logs: https://github.com/onthegomap/planetiler/actions/runs/11988189472 |
msbarry
reviewed
Nov 17, 2024
planetiler-core/src/main/java/com/onthegomap/planetiler/reader/osm/PbfDecoder.java
Outdated
Show resolved
Hide resolved
planetiler-core/src/main/java/com/onthegomap/planetiler/reader/osm/PbfDecoder.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Thank you for fixing all open issues - I didn't find free time to do it so quickly. I successfully tested the current main branch without any additional patches on a LZ4 compressed planet file. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.