Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Visvalingam Whyatt Simplifier #1109

Merged
merged 9 commits into from
Nov 25, 2024
Merged

Add Visvalingam Whyatt Simplifier #1109

merged 9 commits into from
Nov 25, 2024

Conversation

msbarry
Copy link
Contributor

@msbarry msbarry commented Nov 22, 2024

Add a new VWSimplifier that simplifies lines and polygons using the Visvalingam Whyatt algorithm that computes the triangle area formed by each 3 consecutive points and drops points with the minimum area until a certain minArea tolerance is reached. You can use it on features using feature.setSimplifyMethod(SimplifyMethod.RETAIN_EFFECTIVE_AREAS).setPixelTolerance(sqrtOfMinTriangleArea). The pixel tolerance gets squared to compute the min area threshold so that tolerances can be used interchangeably between the default Douglas Peucker (RETAIN_IMPORTANT_POINTS) and VW.

Followups:

  • let users specify a GeometryPipeline on features that apply a series of transformations to it in pixel-space so that you can configure the VW parameters more precisely
  • add an option to avoid dropping vertices that would create a self-intersection with an existing vertex (see https://www.jasondavies.com/simplify/#pseudocode)
  • add an option to only simplify polygons outwards so that it only creates more overlap between adjacent polygons when they get merged

Fixes #1105

Copy link

github-actions bot commented Nov 22, 2024

This Branch b2e0fed Base 292dc78
0:01:11 DEB [archive] - Tile stats:
0:01:11 DEB [archive] - Biggest tiles (gzipped)
1. 14/4942/6092 (157k) https://onthegomap.github.io/planetiler-demo/#14.5/41.82864/-71.40015 (poi:85k)
2. 9/154/190 (144k) https://onthegomap.github.io/planetiler-demo/#9.5/41.77078/-71.36719 (landcover:85k)
3. 10/308/380 (136k) https://onthegomap.github.io/planetiler-demo/#10.5/41.90214/-71.54297 (landcover:66k)
4. 10/308/381 (135k) https://onthegomap.github.io/planetiler-demo/#10.5/41.63994/-71.54297 (landcover:72k)
5. 14/4941/6092 (112k) https://onthegomap.github.io/planetiler-demo/#14.5/41.82864/-71.42212 (poi:64k)
6. 14/4941/6093 (111k) https://onthegomap.github.io/planetiler-demo/#14.5/41.81227/-71.42212 (building:62k)
7. 14/4940/6092 (100k) https://onthegomap.github.io/planetiler-demo/#14.5/41.82864/-71.44409 (building:92k)
8. 11/616/762 (99k) https://onthegomap.github.io/planetiler-demo/#11.5/41.7057/-71.63086 (landcover:71k)
9. 14/4942/6091 (96k) https://onthegomap.github.io/planetiler-demo/#14.5/41.84501/-71.40015 (building:79k)
10. 11/616/761 (95k) https://onthegomap.github.io/planetiler-demo/#11.5/41.83679/-71.63086 (landcover:72k)
0:01:11 DEB [archive] - Max tile sizes
                      z0    z1    z2    z3    z4    z5    z6    z7    z8    z9   z10   z11   z12   z13   z14   all
           boundary  151   336   409   544   872   332   437   552   802  1.6k    2k  6.9k  6.2k  5.6k  4.5k  6.9k
              water 7.7k  3.7k  8.6k  5.5k  2.6k  5.1k   15k   18k   16k   26k   15k   13k   17k   15k   12k   26k
              place    0     0   441   441   441   640   714    1k  1.6k  3.1k  5.7k  3.3k  1.7k   803   948  5.7k
            landuse    0     0     0     0   549   695  1.6k  6.7k   17k   44k   59k   50k   38k   19k   12k   59k
     transportation    0     0     0     0   311   774  1.2k    4k  5.6k   17k   13k   17k   62k   47k   33k   62k
           waterway    0     0     0     0   112   119     0     0     0    3k  2.3k    2k  2.1k  4.9k  2.4k  4.9k
               park    0     0     0     0     0     0  1.3k  4.3k  9.7k   18k   13k  8.2k  3.7k  3.4k  4.4k   18k
transportation_name    0     0     0     0     0     0   287   364  1.1k  1.9k  5.5k  4.7k  3.9k  3.4k   18k   18k
          landcover    0     0     0     0     0     0     0  9.6k   29k   85k   72k   81k   53k   30k   25k   85k
      mountain_peak    0     0     0     0     0     0     0  1.1k  1.8k  3.4k  4.3k  2.8k  1.4k  1.4k   869  4.3k
         water_name    0     0     0     0     0     0     0     0     0   486   461   433   452  1.2k  1.5k  1.5k
    aerodrome_label    0     0     0     0     0     0     0     0     0     0   666   328   273   221   221   666
            aeroway    0     0     0     0     0     0     0     0     0     0  1.6k  2.1k    3k  3.4k  2.8k  3.4k
                poi    0     0     0     0     0     0     0     0     0     0     0     0   568   565   85k   85k
           building    0     0     0     0     0     0     0     0     0     0     0     0     0   59k   92k   92k
        housenumber    0     0     0     0     0     0     0     0     0     0     0     0     0     0   35k   35k
          full tile 7.9k    4k  9.5k  6.4k  3.7k    6k   20k   40k   82k  195k  182k  135k  113k  128k  247k  247k
            gzipped 6.2k  3.5k  7.1k  5.2k  3.1k  4.8k   14k   28k   59k  144k  136k   99k   83k   92k  157k  157k
0:01:11 DEB [archive] -    Max tile: 247k (gzipped: 157k)
0:01:11 DEB [archive] -    Avg tile: 5.4k (gzipped: 4k) using weighted average based on OSM traffic
0:01:11 DEB [archive] -     # tiles: 4,115,031
0:01:11 DEB [archive] -  # features: 5,518,011
0:01:11 INF [archive] - Finished in 19s cpu:1m11s avg:3.7
0:01:11 INF [archive] -   read    1x(3% 0.6s wait:18s done:1s)
0:01:11 INF [archive] -   encode  4x(55% 11s wait:2s)
0:01:11 INF [archive] -   write   1x(22% 4s wait:13s)
0:01:11 INF [archive] - Finished in 1m12s cpu:3m36s gc:1s avg:3
0:01:11 INF [archive] - FINISHED!
0:01:11 INF [archive] - 
0:01:11 INF [archive] - ----------------------------------------
0:01:11 INF [archive] - data errors:
0:01:11 INF [archive] - 	render_snap_fix_input	16,675
0:01:11 INF [archive] - 	osm_multipolygon_missing_way	360
0:01:11 INF [archive] - 	osm_boundary_missing_way	66
0:01:11 INF [archive] - 	merge_snap_fix_input	12
0:01:11 INF [archive] - 	feature_centroid_if_convex_osm_invalid_multipolygon_empty_after_fix	2
0:01:11 INF [archive] - 	render_snap_fix_input2	1
0:01:11 INF [archive] - 	omt_fix_water_before_ne_intersect	1
0:01:11 INF [archive] - 	feature_polygon_osm_invalid_multipolygon_empty_after_fix	1
0:01:11 INF [archive] - 	feature_point_on_surface_osm_invalid_multipolygon_empty_after_fix	1
0:01:11 INF [archive] - ----------------------------------------
0:01:11 INF [archive] - 	overall          1m12s cpu:3m36s gc:1s avg:3
0:01:11 INF [archive] - 	lake_centerlines 4s cpu:5s avg:1.4
0:01:11 INF [archive] - 	  read     1x(12% 0.5s done:3s)
0:01:11 INF [archive] - 	  process  4x(0% 0s done:3s)
0:01:11 INF [archive] - 	  write    1x(0% 0s done:3s)
0:01:11 INF [archive] - 	water_polygons   14s cpu:39s avg:2.7
0:01:11 INF [archive] - 	  read     1x(42% 6s done:7s)
0:01:11 INF [archive] - 	  process  4x(26% 4s wait:4s done:5s)
0:01:11 INF [archive] - 	  write    1x(4% 0.5s wait:9s done:5s)
0:01:11 INF [archive] - 	natural_earth    12s cpu:18s avg:1.6
0:01:11 INF [archive] - 	  read     1x(52% 6s done:5s)
0:01:11 INF [archive] - 	  process  4x(7% 0.8s wait:6s done:5s)
0:01:11 INF [archive] - 	  write    1x(0% 0s wait:6s done:5s)
0:01:11 INF [archive] - 	osm_pass1        2s cpu:6s avg:3.1
0:01:11 INF [archive] - 	  read     1x(2% 0s wait:2s)
0:01:11 INF [archive] - 	  parse    4x(32% 0.6s)
0:01:11 INF [archive] - 	  process  1x(65% 1s)
0:01:11 INF [archive] - 	osm_pass2        18s cpu:1m12s avg:3.9
0:01:11 INF [archive] - 	  read     1x(0% 0s wait:10s done:8s)
0:01:11 INF [archive] - 	  process  4x(75% 14s)
0:01:11 INF [archive] - 	  write    1x(2% 0.4s wait:18s)
0:01:11 INF [archive] - 	ne_lakes         0s cpu:0s avg:0
0:01:11 INF [archive] - 	boundaries       0s cpu:0s avg:1.4
0:01:11 INF [archive] - 	agg_stop         0s cpu:0s avg:0
0:01:11 INF [archive] - 	sort             1s cpu:3s avg:2.6
0:01:11 INF [archive] - 	  worker  1x(52% 0.7s)
0:01:11 INF [archive] - 	archive          19s cpu:1m11s avg:3.7
0:01:11 INF [archive] - 	  read    1x(3% 0.6s wait:18s done:1s)
0:01:11 INF [archive] - 	  encode  4x(55% 11s wait:2s)
0:01:11 INF [archive] - 	  write   1x(22% 4s wait:13s)
0:01:11 INF [archive] - ----------------------------------------
0:01:11 INF [archive] - 	archive	108MB
0:01:11 INF [archive] - 	features	284MB
-rw-r--r-- 1 runner docker 87M Nov 25 11:29 run.jar
0:01:04 DEB [archive] - Tile stats:
0:01:04 DEB [archive] - Biggest tiles (gzipped)
1. 14/4942/6092 (157k) https://onthegomap.github.io/planetiler-demo/#14.5/41.82864/-71.40015 (poi:85k)
2. 9/154/190 (144k) https://onthegomap.github.io/planetiler-demo/#9.5/41.77078/-71.36719 (landcover:85k)
3. 10/308/380 (136k) https://onthegomap.github.io/planetiler-demo/#10.5/41.90214/-71.54297 (landcover:66k)
4. 10/308/381 (135k) https://onthegomap.github.io/planetiler-demo/#10.5/41.63994/-71.54297 (landcover:72k)
5. 14/4941/6092 (112k) https://onthegomap.github.io/planetiler-demo/#14.5/41.82864/-71.42212 (poi:64k)
6. 14/4941/6093 (111k) https://onthegomap.github.io/planetiler-demo/#14.5/41.81227/-71.42212 (building:62k)
7. 14/4940/6092 (100k) https://onthegomap.github.io/planetiler-demo/#14.5/41.82864/-71.44409 (building:92k)
8. 11/616/762 (99k) https://onthegomap.github.io/planetiler-demo/#11.5/41.7057/-71.63086 (landcover:71k)
9. 14/4942/6091 (96k) https://onthegomap.github.io/planetiler-demo/#14.5/41.84501/-71.40015 (building:79k)
10. 11/616/761 (95k) https://onthegomap.github.io/planetiler-demo/#11.5/41.83679/-71.63086 (landcover:72k)
0:01:04 DEB [archive] - Max tile sizes
                      z0    z1    z2    z3    z4    z5    z6    z7    z8    z9   z10   z11   z12   z13   z14   all
           boundary  151   336   409   544   872   332   437   552   802  1.6k    2k  6.9k  6.2k  5.6k  4.5k  6.9k
              water 7.7k  3.7k  8.6k  5.5k  2.6k  5.1k   15k   18k   16k   26k   15k   13k   17k   15k   12k   26k
              place    0     0   441   441   441   640   714    1k  1.6k  3.1k  5.7k  3.3k  1.7k   803   948  5.7k
            landuse    0     0     0     0   549   695  1.6k  6.7k   17k   44k   59k   50k   38k   19k   12k   59k
     transportation    0     0     0     0   311   774  1.2k    4k  5.6k   17k   13k   17k   62k   47k   33k   62k
           waterway    0     0     0     0   112   119     0     0     0    3k  2.3k    2k  2.1k  4.9k  2.4k  4.9k
               park    0     0     0     0     0     0  1.3k  4.3k  9.7k   18k   13k  8.2k  3.7k  3.4k  4.4k   18k
transportation_name    0     0     0     0     0     0   287   364  1.1k  1.9k  5.5k  4.7k  3.9k  3.4k   18k   18k
          landcover    0     0     0     0     0     0     0  9.6k   29k   85k   72k   81k   53k   30k   25k   85k
      mountain_peak    0     0     0     0     0     0     0  1.1k  1.8k  3.4k  4.3k  2.8k  1.4k  1.4k   869  4.3k
         water_name    0     0     0     0     0     0     0     0     0   486   461   433   452  1.2k  1.5k  1.5k
    aerodrome_label    0     0     0     0     0     0     0     0     0     0   666   328   273   221   221   666
            aeroway    0     0     0     0     0     0     0     0     0     0  1.6k  2.1k    3k  3.4k  2.8k  3.4k
                poi    0     0     0     0     0     0     0     0     0     0     0     0   568   565   85k   85k
           building    0     0     0     0     0     0     0     0     0     0     0     0     0   59k   92k   92k
        housenumber    0     0     0     0     0     0     0     0     0     0     0     0     0     0   35k   35k
          full tile 7.9k    4k  9.5k  6.4k  3.7k    6k   20k   40k   82k  195k  182k  135k  113k  128k  247k  247k
            gzipped 6.2k  3.5k  7.1k  5.2k  3.1k  4.8k   14k   28k   59k  144k  136k   99k   83k   92k  157k  157k
0:01:04 DEB [archive] -    Max tile: 247k (gzipped: 157k)
0:01:04 DEB [archive] -    Avg tile: 5.4k (gzipped: 4k) using weighted average based on OSM traffic
0:01:04 DEB [archive] -     # tiles: 4,115,031
0:01:04 DEB [archive] -  # features: 5,518,011
0:01:04 INF [archive] - Finished in 19s cpu:1m11s avg:3.7
0:01:04 INF [archive] -   read    1x(3% 0.5s wait:18s done:1s)
0:01:04 INF [archive] -   encode  4x(55% 11s wait:2s)
0:01:04 INF [archive] -   write   1x(22% 4s wait:13s)
0:01:04 INF [archive] - Finished in 1m4s cpu:3m29s gc:1s avg:3.3
0:01:04 INF [archive] - FINISHED!
0:01:04 INF [archive] - 
0:01:04 INF [archive] - ----------------------------------------
0:01:04 INF [archive] - data errors:
0:01:04 INF [archive] - 	render_snap_fix_input	16,675
0:01:04 INF [archive] - 	osm_multipolygon_missing_way	360
0:01:04 INF [archive] - 	osm_boundary_missing_way	66
0:01:04 INF [archive] - 	merge_snap_fix_input	12
0:01:04 INF [archive] - 	feature_centroid_if_convex_osm_invalid_multipolygon_empty_after_fix	2
0:01:04 INF [archive] - 	render_snap_fix_input2	1
0:01:04 INF [archive] - 	omt_fix_water_before_ne_intersect	1
0:01:04 INF [archive] - 	feature_polygon_osm_invalid_multipolygon_empty_after_fix	1
0:01:04 INF [archive] - 	feature_point_on_surface_osm_invalid_multipolygon_empty_after_fix	1
0:01:04 INF [archive] - ----------------------------------------
0:01:04 INF [archive] - 	overall          1m4s cpu:3m29s gc:1s avg:3.3
0:01:04 INF [archive] - 	lake_centerlines 2s cpu:5s avg:2.4
0:01:04 INF [archive] - 	  read     1x(20% 0.5s done:2s)
0:01:04 INF [archive] - 	  process  4x(0% 0s done:2s)
0:01:04 INF [archive] - 	  write    1x(0% 0s done:2s)
0:01:04 INF [archive] - 	water_polygons   14s cpu:39s avg:2.7
0:01:04 INF [archive] - 	  read     1x(42% 6s done:7s)
0:01:04 INF [archive] - 	  process  4x(26% 4s wait:4s done:5s)
0:01:04 INF [archive] - 	  write    1x(4% 0.5s wait:9s done:5s)
0:01:04 INF [archive] - 	natural_earth    6s cpu:13s avg:2
0:01:04 INF [archive] - 	  read     1x(95% 6s)
0:01:04 INF [archive] - 	  process  4x(13% 0.8s wait:6s)
0:01:04 INF [archive] - 	  write    1x(0% 0s wait:6s)
0:01:04 INF [archive] - 	osm_pass1        2s cpu:6s avg:3.2
0:01:04 INF [archive] - 	  read     1x(2% 0s wait:2s)
0:01:04 INF [archive] - 	  parse    4x(32% 0.6s)
0:01:04 INF [archive] - 	  process  1x(71% 1s)
0:01:04 INF [archive] - 	osm_pass2        18s cpu:1m10s avg:3.9
0:01:04 INF [archive] - 	  read     1x(0% 0s wait:10s done:8s)
0:01:04 INF [archive] - 	  process  4x(77% 14s)
0:01:04 INF [archive] - 	  write    1x(2% 0.4s wait:17s)
0:01:04 INF [archive] - 	ne_lakes         0s cpu:0s avg:0
0:01:04 INF [archive] - 	boundaries       0s cpu:0s avg:2.5
0:01:04 INF [archive] - 	agg_stop         0s cpu:0s avg:0
0:01:04 INF [archive] - 	sort             1s cpu:3s avg:2.6
0:01:04 INF [archive] - 	  worker  1x(54% 0.7s)
0:01:04 INF [archive] - 	archive          19s cpu:1m11s avg:3.7
0:01:04 INF [archive] - 	  read    1x(3% 0.5s wait:18s done:1s)
0:01:04 INF [archive] - 	  encode  4x(55% 11s wait:2s)
0:01:04 INF [archive] - 	  write   1x(22% 4s wait:13s)
0:01:04 INF [archive] - ----------------------------------------
0:01:04 INF [archive] - 	archive	108MB
0:01:04 INF [archive] - 	features	284MB
-rw-r--r-- 1 runner docker 87M Nov 25 11:30 run.jar

Full logs: https://github.com/onthegomap/planetiler/actions/runs/12009047233

Copy link

Quality Gate Failed Quality Gate failed

Failed conditions
11.8% Duplication on New Code (required ≤ 5%)

See analysis details on SonarQube Cloud

@msbarry msbarry merged commit cbeba1b into main Nov 25, 2024
11 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FEATURE] Consider Visvalingam-Whyatt algorithm for simplification
1 participant