Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter out points when min size is set #1132

Merged
merged 3 commits into from
Dec 20, 2024
Merged

Filter out points when min size is set #1132

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5e86826
filter out points when min size is set
msbarry Dec 19, 2024
38b9c60
Update PlanetilerTests.java
msbarry Dec 20, 2024
5b94674
Update PlanetilerTests.java
msbarry Dec 20, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion planetiler-core/src/main/java/com/onthegomap/planetiler/render/FeatureRenderer.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ public void accept(FeatureCollector.Feature feature) {
} else {
if (minSize > 0) {
if (geometry instanceof Puntal) {
if (!feature.source().isPoint() && feature.getSourceFeaturePixelSizeAtZoom(zoom) < minSize) {
if (feature.getSourceFeaturePixelSizeAtZoom(zoom) < minSize) {
// don't emit points if the line or polygon feature it came from was too small
continue;
}
Expand Down
41 changes: 41 additions & 0 deletions planetiler-core/src/test/java/com/onthegomap/planetiler/PlanetilerTests.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -430,6 +430,47 @@ void testLabelGridLimit() throws Exception {
), results.tiles);
}


@Test
void testMinSize() throws Exception {
double x = 0.5 + Z14_WIDTH / 4;
double y = 0.5 + Z14_WIDTH / 4;
double lat = GeoUtils.getWorldLat(y);
double lng = GeoUtils.getWorldLon(x);
double delta = 5e-5;

var results = runWithReaderFeatures(
Map.of("threads", "1", "maxzoom", "15"),
List.of(
newReaderFeature(newPoint(lng, lat), Map.of(
"type", "point"
)),
newReaderFeature(rectangle(lng - delta, lat - delta, lng + delta, lat + delta), Map.of(
"type", "poly"
)),
newReaderFeature(newLineString(lng - delta, lat, lng + delta, lat), Map.of(
"type", "line"
))
),
(in, features) -> features.centroid("layer")
.setZoomRange(13, 15)
.setMinPixelSizeAtAllZooms(1)
.inheritAttrFromSource("type")
);

assertEquals(Map.of(
TileCoord.ofXYZ(Z15_TILES / 2, Z15_TILES / 2, 15), List.of(
feature(newPoint(128, 128), Map.of("type", "line")),
feature(newPoint(128, 128), Map.of("type", "poly"))
// omit point when min size is set
),
TileCoord.ofXYZ(Z14_TILES / 2, Z14_TILES / 2, 14), List.of(
feature(newPoint(64, 64), Map.of("type", "line")),
feature(newPoint(64, 64), Map.of("type", "poly"))
) // features are too small at z13
), results.tiles);
}

@ParameterizedTest
@CsvSource({
"false,RETAIN_IMPORTANT_POINTS",
Expand Down
Loading