-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sort merged vector tile features by hilbert order #673
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/onthegomap/planetiler/actions/runs/6312437079 ℹ️ Base Logs 1b53493
ℹ️ This Branch Logs 85fb271
|
Kudos, SonarCloud Quality Gate passed! |
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Slight improvement to utilities from #669 to sort geometries with the same attributes by hilbert index before merging them into a multigeometry. This helps because every x/y command in a multigeometry is specified as a zig-zag-encoded offset from the previous x/y coordinate in an int array (see spec). That int array gets varint encoded to bytes by the protobuf encoder so sorting by hilbert order minimizes the x/y distance between subsequent geometries.
Also added a
layer_geometries
column to layerstats so it becomes more clear how many geometries are contained inside multigeometry features inside a tile.This has no impact on weighted average tile size, but it does reduce the largest housenumber, building, and transportation layers by an additional 10-20% and the overall largest gzipped tile by 17% (680->566kb).
The impact on tile generation time appears to be minimal, but if it causes issues in the future we can limit so that we only sort features when more than a certain number (50-1000?) get merged into a multigeometry.
Before:
After: