-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Attempt to fix IOException/GOAWAY happening within parseResults() #818
Merged
msbarry
merged 5 commits into
onthegomap:main
from
phanecak-maptiler:handle_goaway_from_wikidata_within_parseResults
Feb 16, 2024
Merged
Attempt to fix IOException/GOAWAY happening within parseResults() #818
msbarry
merged 5 commits into
onthegomap:main
from
phanecak-maptiler:handle_goaway_from_wikidata_within_parseResults
Feb 16, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
https://github.com/onthegomap/planetiler/actions/runs/7930676315 ℹ️ Base Logs e9a2bcc
ℹ️ This Branch Logs 1b92f57
|
msbarry
reviewed
Feb 16, 2024
planetiler-core/src/main/java/com/onthegomap/planetiler/util/Wikidata.java
Show resolved
Hide resolved
msbarry
reviewed
Feb 16, 2024
planetiler-core/src/main/java/com/onthegomap/planetiler/util/Wikidata.java
Show resolved
Hide resolved
…with http_retry_wait
msbarry
reviewed
Feb 16, 2024
planetiler-core/src/main/java/com/onthegomap/planetiler/config/PlanetilerConfig.java
Outdated
Show resolved
Hide resolved
planetiler-core/src/main/java/com/onthegomap/planetiler/util/Wikidata.java
Outdated
Show resolved
Hide resolved
msbarry
reviewed
Feb 16, 2024
planetiler-core/src/main/java/com/onthegomap/planetiler/config/PlanetilerConfig.java
Outdated
Show resolved
Hide resolved
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix #817 by moving
parseResults()
into the the retry loop, intotry+catch
statement. Retries afterGOAWAY
are done after 5 seconds (configurable withhttp_retry_wait
) to give server some room to recover.I've tested the code, but I was unable to fully reproduce GOAWAY inside
parseResults()
hence I'm not sure the fix is fully effective.