Encode OSM node/way/relation in vector tile feature id #826
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full logs: https://github.com/onthegomap/planetiler/actions/runs/9711262625 |
msbarry
changed the title
|
|
We may consider adding a |
zstadler
added a commit
to zstadler/planetiler
that referenced
this pull request
Jun 2, 2024
- Create a default implementation for `featureId()` in `sourceFeature` - Implement `featureId()` differently for `OsmElement`. - Remove previous implementations of featureId()` elsewhere. - Replace `source.id()` with `source.featureId()` in `FeatureCollector`, `OpenMapTilesMapping`, `OsmFeature`. - Add `id` and `withId()` to `TestUtil.TopoGeometry.ComparableFeature` and updates the applicable tests. [Based on onthegomap#826] Branch status: - Branch and tests are passing compilation - Output tiles have the new Feature ID values for OSM elements - Two tests are failing and were temporarily disabled: `testPreprocessOsmNodesAndWays` and `integrationTest`
zstadler
added a commit
to zstadler/planetiler
that referenced
this pull request
Jun 3, 2024
Finish incomplete merger of `TestUtils.java` from onthegomap#826 Update expected ids in `OsmQaTilesTest.java` Branch status: - Branch and tests are passing compilation - Output tiles have the new Feature ID values for OSM elements - One test is failing and was temporarily disabled: `testPreprocessOsmNodesAndWays`
zstadler
added a commit
to zstadler/planetiler
that referenced
this pull request
Jun 3, 2024
- Create a default implementation for `featureId()` in `sourceFeature` - Implement `featureId()` differently for `OsmElement`. - Remove previous implementations of featureId()` elsewhere. - Replace `source.id()` with `source.featureId()` in `FeatureCollector`, `OpenMapTilesMapping`, `OsmFeature`. - Add `id` and `withId()` to `TestUtil.TopoGeometry.ComparableFeature` and updates the applicable tests. [Based on onthegomap#826] Branch status: - Branch and tests are passing compilation - Output tiles have the new Feature ID values for OSM elements - Two tests are failing and were temporarily disabled: `testPreprocessOsmNodesAndWays` and `integrationTest`
zstadler
added a commit
to zstadler/planetiler
that referenced
this pull request
Jun 3, 2024
Finish incomplete merger of `TestUtils.java` from onthegomap#826 Update expected ids in `OsmQaTilesTest.java` Branch status: - Branch and tests are passing compilation - Output tiles have the new Feature ID values for OSM elements - One test is failing and was temporarily disabled: `testPreprocessOsmNodesAndWays`
By default, `sourceFeature.featureIdFromElement()` is using `sourceFeature.id()`, but it allows overiding it in sub-classes, such as `OsmElement`.
For OSM elements, the feature id encodes the origin of a vector tile feature - an OSM node, way, or relation.
It uses the formula
`{vector tile feature id} = {osm id} * 10 + {1 for node, 2 for way, 3 for relation}`.
See #824
- A default implementation for `featureIdFromElement()` added to `sourceFeature`
- A `OsmElement.type()` implemented in its sub-classes to provide the OSM element type.
- `OsmElement.featureIdFromElement()` uses `type()` to implemented the above formula.
- `source.featureIdFromElement()` is used instead of `source.id()` when converting a source element to a tile feature in `FeatureCollector`, `OpenMapTilesMapping`, and `OsmFeature`.
- Additional constructors to avoid the use of `withId()` in tests
|
msbarry
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Encode what source a feature comes from in its ID:
By default
--feature-source-id-multiplier=10but you can set to--feature-source-id-multiplier=falseto disable.See #824