-
-
Notifications
You must be signed in to change notification settings - Fork 117
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Iniitial geoparquet support #888
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Full logs: https://github.com/onthegomap/planetiler/actions/runs/9189106518 |
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add initial geoparquet support to planetiler for reading datasets like overture maps.
Planetiler will attempt to read geoparquet metadata from the "geo" file metadata field to determine which field contains the default geometry on each field and how to deserialize it (including geoarrow geometries). If that's missing, it will fall back to
geometry
,wkb_geometry
, orwkt_geometry
field (similar to gdal).Parquet supports structured attributes like maps and lists. For now the
SourceFeature
API is unchanged, so you may get back aMap<String, List<Object>>
fromfeature.getTag(name)
. A future PR will add more convenient API for working with structured tags.The
--bounds
bbox argument gets converted to a push-down predicate that lets planetiler avoid reading entire files, row groups, and records that fall outside the bounding box. For example since overture data is sorted roughly geographically if you specify a bounding box for a city like Boston, it can select and process all the features in less than 5 seconds.The apache java parquet reader is tightly coupled to the rest of hadoop and cannot easily be used on its own (see https://issues.apache.org/jira/browse/PARQUET-1126), so to avoid pulling in many mb's of dependencies this PR uses the parquet-floor project that uses the minimal set of dependencies and stubs-out the rest so the jar size only goes up from 70 to 84mb.
Planned for followup PRs:
feature.getTag
can return a nested map or list on parquet featuresputAttrBetween
utility for breaking a linestring up into segments based on attributes that apply only to part of the line