Add multi pretransaction support #1026
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* add block height check when run transaction * finetune the config height * update blockheight, estimate by ((two weeks block) * 2 + current blockheight) * make pickitem support both big.int and bytearray. ensure big.int do not expose to user * update opcode hight constant to future block
* fix Vbft Block serdes * enforce merkleRoot data in Block msg * fix error handlings
| return ResponsePack(berr.INVALID_PARAMS) | ||
| } | ||
| res := make([]interface{}, 0) | ||
| for _, param := range paras { |
| @@ -220,6 +222,8 @@ func (this *restServer) getParams(r *http.Request, url string, req map[string]in | |||
| req["Hash"], req["Raw"] = getParam(r, "hash"), r.FormValue("raw") | |||
| case POST_RAW_TX: | |||
| req["PreExec"] = r.FormValue("preExec") | |||
| case POST_MULTI_RAW_TX: | |||
| req["PreExec"] = r.FormValue("preExec") | |||
There was a problem hiding this comment.
MULTI_RAW_TX only supports preExec ?
http/base/rpc/interfaces.go
Outdated
| @@ -303,6 +303,39 @@ func SendRawTransaction(params []interface{}) map[string]interface{} { | |||
| return responseSuccess(hash.ToHexString()) | |||
| } | |||
|
|
|||
| // multi pre tx, [tx1, tx2,tx3] | |||
| func MultiPreTransaction(params []interface{}) map[string]interface{} { | |||
There was a problem hiding this comment.
why not reuse the above function?
http/base/rest/interfaces.go
Outdated
| @@ -287,6 +287,45 @@ func SendRawTransaction(cmd map[string]interface{}) map[string]interface{} { | |||
| return resp | |||
| } | |||
|
|
|||
| // multi pre tx, [tx1, tx2,tx3] | |||
| func MultiPreTransaction(params map[string]interface{}) map[string]interface{} { | |||
There was a problem hiding this comment.
rename as "PreexecuteMultiTransactions" ?
|
what‘s is the usage scenario? |
laizy
force-pushed
the
master
branch
2 times, most recently
from
8c8ee59 to
dc599e9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.