-
Notifications
You must be signed in to change notification settings - Fork 290
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
speedup import block processing #1093
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fixed int128::min() loose precion bug * Update vm/neovm/params_builder.go Co-Authored-By: laizy <[email protected]>
* update ontid with new features: 1. controller 2. new recovery design * update events and fix bugs * add methods of revoking ONT ID * update GetDDO and registered methods * update delete attributes * fix bug in getController * add copyrights * fix bugs and add tests * add copyright * update serialization * update checkWitness in ontid * fix bugs * fix bugs in using revoked key * error handling * add limitations * limit attribute number * update * change limit to owner keys * fix bugs * limit total size of owner's keys
* save empty block * handle empty block * clear code * fix merkletreeroot check * fix some bug * fix emptyblockamount bug * fix some bug
cmd/import_cmd.go
Outdated
if err != nil { | ||
return fmt.Errorf("read block data height:%d error:%s", i, err) | ||
var readErr error | ||
blockes := make(chan *types.Block, 10) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
blocks?
or blockC?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
replace and fixed in pr- #1112
replaced by #1112 to change branch back to |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.