Merge to master: Release 3.0.1 #839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…button in browse results (#828) * fix broken switch style when using a long text with it * don't show current portal name button in browse page results * adjest switch text max-width only for browse filter * don't show portal name only if it's unique in browse page federated results
* replace unexisting key :ontology_acronym and get the ontology acronym from the ontology_id when checking ontology duplication in federation * clean code of merge federated results method
* update select_language_label helper to select f no english found any language remaining over the not tagged * disable label ajax container * create label fetch component that for a id/uri fetch its label if found * add the possibility for the turbo frame to have custom error messages * remove and replace ontology entities link helpers * replace the label-ajax stimulus with turbo frame using ajax_link_chip * fix an uncatched error in concept label helper * remove label-ajax stimulus code * remove bp_ajax_controller old js code and update mappings to use the label fetcher component * fix bug of not opening eternal mapping details popup * remove label_link component * add a helper for the label fetcher component for clarity * add extern_link argument to ajax_link_chip to enforce external or not
* update select_language_label helper to select f no english found any language remaining over the not tagged * remove ontology bridge code * remove ont_viewer data jquery code * remove no existent fetch_results action code
* in home page move metrics up and have news if not enabled * move metrics section up in the summary page * Update home statistics layout to improve balance and alignment --------- Co-authored-by: Bilel KIHAL <[email protected]>
…746) Co-authored-by: Bilel KIHAL <[email protected]>
* include all when loading the user, to make sure we get ontologies acronyms in usrer.subscription list * fix watch button count
…748) * don't auto select as local language a disabled language (e.g DE) * enforce resolvability-checks icons to always use portal primary color * remove enforcing resolvability color
|
@Bilelkihal here we need to fix the tests before deploying to stage or merging. |
Test fixed in #844 |
…n selection showing content missing or an error alert (#846) * enforce add comment and proposal buttons to use turbo top frame to prevent content missing * make the notes form use the correct button component * fix property content missing message * fix not selecting a collection message error
…ept mapping table API calls (#842) * fix label ajax for no more existent ontologies * use label fetched for classes in the notes table * optimize the calls done for the concept mapping table * fix home page bubbles if no analytics enabled
…n link (#850) * detect if the taxonomy description is a link and handle that * make portal name dynamic in taxonomy page description * retouch taxonomy page description * use link? helper in taxonomy card component instead of creating another one
#857) * fix username with the `@` in the usernames * make the user edit as login as work
* fix federated portal button opening in current portal in browse page * make internal federated portal button open in the current tab
This reverts commit 462dc6d.
* fix nil parentCategory issue in nest_categories_children method * add empty illustration if a taxonomy list is empty * remove random code in taxonomy index view file * treat the case when a category is deleted while keeping its id as a parent for a certain category * use empty_state helper in taxonomies page * internationalize no taxonomy is created * use current_user_admin? helper in taxonomies page * use regular button helper in taxonomies page * remove added code just to test in taxonomy page
* fix multislashes added in browse page federation links * ensure trailing slash in federation portals ui and api links * undo extracting normalizing portals urls to a separate function
* include non canonical portals in counting results for each portal * include non canonical portals in counting results for each portal in federated search * use portal_api and portal_ui in counting federation results instead of portal_name
…ponse (#851) * prevent display home portal tooltip if we get a non complete data * show any info we get from the api in portals home page tooltips
Bilelkihal
approved these changes
Nov 28, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tree ViewPrevent word break for the elements #855@symbol in there usernames #857Federated search/browseresults count by portal #870Federated searchresults merging logic #872Backend changes
ontoportal-lirmm/ontologies_api#110
ontoportal-lirmm/ontologies_linked_data#171