Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Migrate to minitest 5 #102

Merged
merged 3 commits into from
Oct 26, 2024

Conversation

syphax-bouazzouni
Copy link

@syphax-bouazzouni syphax-bouazzouni commented Oct 25, 2024

Sync with ncbo#143, ncbo#166, ncbo#133, and NCBO latest API code release.

Changes

  • Migrate to Ruby 3
  • Migrate to Minitest 5
  • NCBO on-demand pull feature
  • NCBO reset password token expiration
  • NCBO disable recommender v1

@syphax-bouazzouni syphax-bouazzouni changed the base branch from master to development October 25, 2024 07:01
…te-to-minitest-5' into feature/migrate-to-minitest-5
@syphax-bouazzouni syphax-bouazzouni force-pushed the feature/migrate-to-minitest-5 branch 2 times, most recently from 83109d0 to 289c532 Compare October 25, 2024 10:39
@syphax-bouazzouni syphax-bouazzouni force-pushed the feature/migrate-to-minitest-5 branch from 289c532 to bd3d004 Compare October 25, 2024 11:13
Copy link

codecov bot commented Oct 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 73.08%. Comparing base (923629e) to head (a5b8cd8).
Report is 32 commits behind head on development.

Additional details and impacted files
@@               Coverage Diff               @@
##           development     #102      +/-   ##
===============================================
+ Coverage        71.85%   73.08%   +1.23%     
===============================================
  Files               67       67              
  Lines             3681     3753      +72     
===============================================
+ Hits              2645     2743      +98     
+ Misses            1036     1010      -26     
Flag Coverage Δ
unittests 73.08% <100.00%> (+1.23%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@syphax-bouazzouni syphax-bouazzouni force-pushed the feature/migrate-to-minitest-5 branch 2 times, most recently from 5739614 to e7c0cba Compare October 25, 2024 12:36
@syphax-bouazzouni syphax-bouazzouni changed the title Feature: migrate to minitest 5 Feature: Migrate to minitest 5 Oct 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant