Fix: Submissions filters with order_by for the same attribute #46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
syphax-bouazzouni
force-pushed
the
fix/submission-filters-endpoints
branch
from
f5b51ed to
25d7f84
Compare
syphax-bouazzouni
added a commit
that referenced
this pull request
Dec 5, 2023
* add request_lang middleware * pin redis gem version to 4.8.1 * update Gemfile.lock * [ontoportal-bot] Gemfile.lock update * [ontoportal-bot] Gemfile.lock update * [ontoportal-bot] Gemfile.lock update * update Gemfile to use ontologies_linked_data new metadata branch * update TestOntologySubmissionsController to be adapted to the new model * [ontoportal-bot] Gemfile.lock update * [ontoportal-bot] Gemfile.lock update * [ontoportal-bot] Gemfile.lock update * in submission_metadata rename display with category * add to submission_metadata description and example fields * add the option to do pagination for the submission endpoint * extract retrieve_latest_submissions method to submission helper * implement apply_filters to submissions endpoint using SPARQL FILTERs * add test for submissions endpoint pagination * [ontoportal-bot] Gemfile.lock update * fix private only submission filter * add hasFormalityLevel filter for submissions endpoint * add for ontology: reviews, notes, projects on the submissions endpoints * bring submission metrics for submissions endpoints * bring all contact attributes if asked in the submissions endpoints * refactor submissions endpoint filters by extracting some methods * add ontology acronym or name filters for submissions endpoints * add submissions endpoint order_by option * [ontoportal-bot] Gemfile.lock update * fix including ontology and contacts in the submissions endpoints * fix list admin filter_access control (e.g for submissions endpoints) * [ontoportal-bot] Gemfile.lock update * check access of ontologies in /ontologies/:acronym/submissions endpoint * include ontology viewOf attribute in the submission endpoints * make apply_filters helper generic for any of model attributes * add Agents controller * add pagination to agents index endpoint if asked * make agents routes work for /Agent and /agent * handle agent indentifiers and affiliations attributes save and update * make agent controller work for affiliations attribute * add agent controller tests * don't update affiliations if only 'id' sent in params * bring identifier attributes when we update an agent * update agent test to work with the new Agent validators * bring the agent attributes on display all of the submissions endpoints * handle exception for class attribute but aren't in populate_from_params * update Gemfile to use development branch of OLD * refactor user controller to extract reset password helpers * remove the send notification on user creation, now handled by user.save * add access token authentication * fix test after enforcing the uniqueness of user emails * fix search test * add oauth_authentication test * bring the correct attributes when the oauth_authenticate is used * Feature: Add support of multilingual search (#40) * update get_term_search_query to support multilanguages search * rename var * fix search lang suffix to use underscore not @ * add multilangual search test --------- Co-authored-by: Syphax Bouazzouni <[email protected]> * add get submission all including all properties test * extract and use submission_include_params where we use submission.bring * use retrieve_submissions helper in the :acronym/submissions endpoint * update Goo version and add submissions filters test * Fix: display contact for get submissions (#45) * add get submission all including all properties test * extract and use submission_include_params where we use submission.bring * use retrieve_submissions helper in the :acronym/submissions endpoint * Fix: Submissions filters with order_by for the same attribute (#46) * add get submission all including all properties test * extract and use submission_include_params where we use submission.bring * use retrieve_submissions helper in the :acronym/submissions endpoint * update Goo version and add submissions filters test * make the ontology submissions endpoint include views * include all metrics attribues in the submissions endpoints (#53) * add ontology submissions filter by status (#56) * add agent usage attribute tests (#55) * Fix: optimize fetching all agents usages query by batch loading them (#57) * add agent usage attribute tests * optimize fetching all agents usages query by batch loading them * Feature: Add ontologies_api docker image build CI (#58) * add docker build CI * Feature: add ontoportal bash script (#59) * add ontoportal bash script to run test and development servers * update README.md * update docker CI to work in production releases * Feature: add ontoportal bash script (#59) * add ontoportal bash script to run test and development servers * update README.md * update docker CI to work in production releases * fix date list properties population helper * Feature: update ontoportal bash script to handle local gems binding (#61) * add ontoportal bash script to run test and development servers * update README.md * update docker CI to work in production releases * update ontoportal script to handle local gems bindq * update ontoportal script to handle binding to local gem for development * fixing the test runner after the new changes in the ontoportal script * add description filter to the submissions endpoint (#62) --------- Co-authored-by: OntoPortal Bot <[email protected]> Co-authored-by: HADDAD Zineddine <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
This PR fixes the following not-working filters and adds a test for all the implemented filters for the submission endpoint.
Fixed filters:
Changes