Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge to master: Release 2.4.1 - Multilingual search and Agent issues fixes #87

Merged
merged 14 commits into from
Aug 8, 2024

Conversation

@syphax-bouazzouni syphax-bouazzouni changed the title Merge to master: Release 2.X.X Merge to master: Release 2.3.6 Jul 19, 2024
Bilelkihal and others added 3 commits July 23, 2024 15:22
* implement ontology agents endpoint

* Move ontology agents method out of agents namespace in agents_controller

* return a list of uniq values, for the endpoint '/ontologies/:acronym/agents' that contains all the agents of the ontology using agents_attrs list

* test for ontology agents endpoing

* add another ontologyin test ontology agents test, and assert only the number of results and the names

---------

Co-authored-by: Bilel KIHAL <[email protected]>
…filter

Fix: Search multilingual values filter
Copy link

codecov bot commented Jul 24, 2024

Codecov Report

Attention: Patch coverage is 95.80420% with 6 lines in your changes missing coverage. Please review.

Project coverage is 71.94%. Comparing base (b8436be) to head (4534006).
Report is 10 commits behind head on master.

Files Patch % Lines
controllers/agents_controller.rb 93.61% 6 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master      #87      +/-   ##
==========================================
+ Coverage   70.78%   71.94%   +1.15%     
==========================================
  Files          65       67       +2     
  Lines        3420     3696     +276     
==========================================
+ Hits         2421     2659     +238     
- Misses        999     1037      +38     
Flag Coverage Δ
unittests 71.94% <95.80%> (+1.15%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Gemfile Outdated Show resolved Hide resolved
Bilelkihal and others added 3 commits August 1, 2024 20:25
… qf paramter (#90)

* fix agents search sensibility

* improve agents search endpoint to search only exact string or substring match

* make the agent search endpoint query filter configurable

---------

Co-authored-by: Syphax <[email protected]>
* remove duplicated agents endpoint ('/Agents')

* put again the Agents endpoint

* hide Agents endpoint in the home endpoint

* fix properties tests

---------

Co-authored-by: Bilel KIHAL <[email protected]>
@syphax-bouazzouni syphax-bouazzouni changed the title Merge to master: Release 2.3.6 Merge to master: Release 2.3.6 - Multilingual search and Agent issues fixes Aug 8, 2024
@syphax-bouazzouni syphax-bouazzouni merged commit b434252 into master Aug 8, 2024
25 checks passed
@syphax-bouazzouni syphax-bouazzouni changed the title Merge to master: Release 2.3.6 - Multilingual search and Agent issues fixes Merge to master: Release 2.4.1 - Multilingual search and Agent issues fixes Oct 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants