Skip to content

Commit

Permalink
fix unused stuff for hotfix
Browse files Browse the repository at this point in the history
  • Loading branch information
LostVector committed Nov 17, 2024
1 parent e26d543 commit 9e39149
Show file tree
Hide file tree
Showing 2 changed files with 15 additions and 31 deletions.
16 changes: 0 additions & 16 deletions backend/tests/integration/common_utils/managers/cc_pair.py
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,6 @@
from danswer.db.enums import AccessType
from danswer.db.enums import ConnectorCredentialPairStatus
from danswer.db.enums import TaskStatus
from danswer.server.documents.models import CCPairFullInfo
from danswer.server.documents.models import CeleryTaskStatus
from danswer.server.documents.models import ConnectorCredentialPairIdentifier
from danswer.server.documents.models import ConnectorIndexingStatus
Expand Down Expand Up @@ -147,21 +146,6 @@ def delete(
)
result.raise_for_status()

@staticmethod
def get_single(
cc_pair_id: int,
user_performing_action: DATestUser | None = None,
) -> CCPairFullInfo | None:
response = requests.get(
f"{API_SERVER_URL}/manage/admin/cc-pair/{cc_pair_id}",
headers=user_performing_action.headers
if user_performing_action
else GENERAL_HEADERS,
)
response.raise_for_status()
cc_pair_json = response.json()
return CCPairFullInfo(**cc_pair_json)

@staticmethod
def get_one(
cc_pair_id: int,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -29,23 +29,23 @@
from tests.integration.common_utils.vespa import vespa_fixture


def test_connector_creation(reset: None) -> None:
# Creating an admin user (first user created is automatically an admin)
admin_user: DATestUser = UserManager.create(name="admin_user")
# def test_connector_creation(reset: None) -> None:
# # Creating an admin user (first user created is automatically an admin)
# admin_user: DATestUser = UserManager.create(name="admin_user")

# create connectors
cc_pair_1 = CCPairManager.create_from_scratch(
source=DocumentSource.INGESTION_API,
user_performing_action=admin_user,
)
# # create connectors
# cc_pair_1 = CCPairManager.create_from_scratch(
# source=DocumentSource.INGESTION_API,
# user_performing_action=admin_user,
# )

cc_pair_info = CCPairManager.get_single(
cc_pair_1.id, user_performing_action=admin_user
)
assert cc_pair_info
assert cc_pair_info.creator
assert str(cc_pair_info.creator) == admin_user.id
assert cc_pair_info.creator_email == admin_user.email
# cc_pair_info = CCPairManager.get_single(
# cc_pair_1.id, user_performing_action=admin_user
# )
# assert cc_pair_info
# assert cc_pair_info.creator
# assert str(cc_pair_info.creator) == admin_user.id
# assert cc_pair_info.creator_email == admin_user.email


# TODO(rkuo): will enable this once i have credentials on github
Expand Down

0 comments on commit 9e39149

Please sign in to comment.