Fix document counts #3671
Open
Fix document counts #3671
+184
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
Weves
commented
Jan 14, 2025
| @@ -263,21 +283,6 @@ def index_doc_batch_prepare( | |||
| def filter_documents(document_batch: list[Document]) -> list[Document]: | |||
| documents: list[Document] = [] | |||
| for document in document_batch: | |||
| # Remove any NUL characters from title/semantic_id | |||
There was a problem hiding this comment.
Removing this logic from this func and pushing it to strip_null_characters in run_indexing.py.
This isn't really a "filter" step, and the other function has this exact logic more-or-less, so it feels like it's a better fit there
Weves
force-pushed
the
fix-document-counts
branch
from
2f14420 to
23ad230
Compare
rkuo-danswer
approved these changes
Jan 15, 2025
Weves
force-pushed
the
fix-document-counts
branch
from
d4378bb to
c5e0da0
Compare
Weves
force-pushed
the
fix-document-counts
branch
from
c5e0da0 to
14d5c31
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Addresses two edge cases:
How Has This Been Tested?
Ran indexing locally, verified counts matched as expected.
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.