Added ability to use a tag to insert the current datetime in prompts #3697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
pablonyx
reviewed
Jan 17, 2025
hagen-danswer
force-pushed
the
enable-datetime-awareness
branch
from
4e6cce7 to
46b17e0
Compare
yuhongsun96
reviewed
Jan 18, 2025
| @@ -51,7 +51,7 @@ prompts: | |||
| - name: "OnlyLLM" | |||
| description: "Chat directly with the LLM!" | |||
| system: > | |||
| You are a helpful AI assistant. The current date is DANSWER_DATETIME_REPLACEMENT | |||
| You are a helpful AI assistant. The current date is [[CURRENT_DATETIME]] | |||
yuhongsun96
reviewed
Jan 18, 2025
| @@ -31,15 +31,14 @@ def default_build_system_message( | |||
| prompt_config: PromptConfig, | |||
| ) -> SystemMessage | None: | |||
| system_prompt = prompt_config.system_prompt.strip() | |||
| if prompt_config.datetime_aware: | |||
| system_prompt = add_date_time_to_prompt(prompt_str=system_prompt) | |||
| tag_handled_prompt = handle_onyx_date_awareness( | |||
There was a problem hiding this comment.
what does tag handled mean?
hagen-danswer
force-pushed
the
enable-datetime-awareness
branch
from
84964ca to
fa2ac14
Compare
yuhongsun96
force-pushed
the
enable-datetime-awareness
branch
from
fa2ac14 to
82b606d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
https://linear.app/danswer/issue/DAN-1309/add-datetime-to-assistant-page
How Has This Been Tested?
[Describe the tests you ran to verify your changes]
Backporting (check the box to trigger backport action)
Note: You have to check that the action passes, otherwise resolve the conflicts manually and tag the patches.