feat: oonifindings service #845
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This creates a pytest plugin for clickhouse using the clickhouse docker image as the executor
Create oonifindings service with clickhouse support
hellais
reviewed
Apr 26, 2024
|
|
||
|
|
||
| @pytest.fixture | ||
| def clickhouse_migration(clickhouse): |
There was a problem hiding this comment.
We should for the time being swap this out for pytest-docker based approach: https://github.com/ooni/data/blob/main/oonipipeline/tests/conftest.py#L39
hellais
reviewed
Apr 26, 2024
| # TODO(decfox): try using OONIFindings.validate_model to populate model | ||
| for incident in incidents: | ||
| incident_model = OONIFinding( | ||
| incident_id=incident.id, |
There was a problem hiding this comment.
This should be changed to be id instead of incident_id
hellais
reviewed
Apr 26, 2024
|
|
||
|
|
||
| class OONIFindingBase(BaseModel): | ||
| incident_id: str |
There was a problem hiding this comment.
You can use alias to change the serialization: https://docs.pydantic.dev/latest/concepts/fields/#field-aliases
hellais
reviewed
Apr 26, 2024
| return q[0]["cnt"] > 0 | ||
|
|
||
|
|
||
| class OONIFindingsUpdate(BaseModel): |
There was a problem hiding this comment.
Probably rename this to not conflict with the other OONIFindingsUpdate
|
I'll be rebasing this and pushing a new diff since we want to separate the pytest plugin work from the service |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create oonifindings service with clickhouse support
Closes #814