-
Notifications
You must be signed in to change notification settings - Fork 29
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: oonifindings service #850
Conversation
Create oonifindings service with clickhouse support
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left small comments in the code for stuff we might want to document as future work. Otherwise the tests are green and it runs on my laptop so this is good to go for me.
The next step is to switch from clickhouse over to postgresql.
🐬
@@ -0,0 +1,26 @@ | |||
Copyright 2022-present Open Observatory of Network Interference Foundation (OONI) ETS |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good. We should also remember to update https://github.com/ooni/license/tree/master/software
Thanks! I am going to go ahead and merge. As discussed with @hellais, we should only deploy once we have migrated to postgresql. |
This diff creates a new ECS deployment for the `oonifindings` service. We can land this after we have ooni/backend#850 working. --------- Co-authored-by: decfox <[email protected]>
This diff introduces the oonifindings revamp work with migration to fastapi and clickhouse support.
closes: #814