Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: oonifindings service #850

Merged
merged 16 commits into from
Jun 21, 2024
Merged

feat: oonifindings service #850

merged 16 commits into from
Jun 21, 2024

Conversation

DecFox
Copy link
Contributor

@DecFox DecFox commented May 11, 2024

This diff introduces the oonifindings revamp work with migration to fastapi and clickhouse support.

closes: #814

Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Left small comments in the code for stuff we might want to document as future work. Otherwise the tests are green and it runs on my laptop so this is good to go for me.

The next step is to switch from clickhouse over to postgresql.

🐬

ooniapi/common/src/common/auth.py Show resolved Hide resolved
@@ -0,0 +1,26 @@
Copyright 2022-present Open Observatory of Network Interference Foundation (OONI) ETS
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good. We should also remember to update https://github.com/ooni/license/tree/master/software

@DecFox
Copy link
Contributor Author

DecFox commented Jun 21, 2024

Thanks! I am going to go ahead and merge. As discussed with @hellais, we should only deploy once we have migrated to postgresql.

@DecFox DecFox merged commit d3e6924 into master Jun 21, 2024
5 of 6 checks passed
@hellais hellais deleted the issue/814-oonifindings branch June 26, 2024 08:22
DecFox added a commit to ooni/devops that referenced this pull request Aug 10, 2024
This diff creates a new ECS deployment for the `oonifindings` service.
We can land this after we have ooni/backend#850
working.

---------

Co-authored-by: decfox <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Port findings platform over to new pattern
2 participants