Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more test to oonidata related endpoints #921

Merged
merged 7 commits into from
Jan 24, 2025

Conversation

hynnot
Copy link
Contributor

@hynnot hynnot commented Jan 15, 2025

This PR is about the issue #911

Steps:

  • Add ARGS parameter in the make test command
  • Add E2E tests to list analysis endpoint
  • Add E2E tests to list observations endpoint
  • Add E2E tests to aggregate analysis endpoint
  • Add E2E tests to aggregate observations endpoint
  • Refactor to add two fixtures in conftest to set the since and until params.
  • Create a decorator to pass to int the str probe_asn filter.

Notes:

@hynnot hynnot marked this pull request as ready for review January 20, 2025 09:00
@hynnot hynnot changed the title [DRAFT] ISSUE-911 Add more test to oonidata related endpoints ISSUE-911 Add more test to oonidata related endpoints Jan 20, 2025
@hynnot hynnot requested a review from hellais January 20, 2025 09:00
@hynnot hynnot changed the title ISSUE-911 Add more test to oonidata related endpoints Issue-911 Add more test to oonidata related endpoints Jan 23, 2025
@hynnot hynnot changed the title Issue-911 Add more test to oonidata related endpoints Add more test to oonidata related endpoints Jan 23, 2025
@hellais
Copy link
Member

hellais commented Jan 23, 2025

LGTM!

@hynnot hynnot merged commit 2c33d2b into master Jan 24, 2025
7 checks passed
@hellais hellais deleted the 911-add-more-test-to-oonidata-endpoints branch January 24, 2025 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants