Skip to content

Fix circular dependency in clickhouse proxy #235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 10 commits into from
Apr 29, 2025

Conversation

LDiazN
Copy link
Contributor

@LDiazN LDiazN commented Apr 10, 2025

This diff will fix some issues related to the clickhouse proxy deployment where sometimes you would get a dehydrated error when trying to deploy it, and the solution involved:

  1. Moving out an nginx configuration file related to the proxy server
  2. Restarting nginx
  3. Restarting dehydrated
  4. Moving the nginx configuration back in place
  5. Restarting nginx

The error was caused because dehydrated and nginx weren't running in the correct order in the ansible play, and dehydrated required an nginx restart to work properly.

I fixed the order and added the nginx restart to the dehydrated role

closes #232

After applying this change, the deploy-clickhouse-proxy.yml play should deploy the clickhouse proxy in one go without errors

@LDiazN LDiazN added the bug Something isn't working correctly label Apr 10, 2025
@LDiazN LDiazN requested a review from hellais April 10, 2025 13:40
@LDiazN LDiazN self-assigned this Apr 10, 2025
Copy link

github-actions bot commented Apr 10, 2025

Ansible Run Output 🤖

Ansible Playbook Recap 🔍



Ansible playbook output 📖success

Show Execution

$ ansible-playbook playbook.yml --check --diff -i ../tf/modules/ansible_inventory/inventories/inventory-dev.ini
[WARNING]: provided hosts list is empty, only localhost is available. Note that
the implicit localhost does not match 'all'
[WARNING]: Could not match supplied host pattern, ignoring: monitoring.ooni.org
[WARNING]: Could not match supplied host pattern, ignoring: backend-
hel.ooni.org
[WARNING]: Could not match supplied host pattern, ignoring:
clickhouseproxy.dev.ooni.io
[WARNING]: Could not match supplied host pattern, ignoring:
clickhouseproxy.prod.ooni.io
[WARNING]: Could not match supplied host pattern, ignoring: notebook1.htz-
fsn.prod.ooni.nu
[WARNING]: Could not match supplied host pattern, ignoring: data1.htz-
fsn.prod.ooni.nu
[WARNING]: Could not match supplied host pattern, ignoring: data3.htz-
fsn.prod.ooni.nu
[WARNING]: Could not match supplied host pattern, ignoring: openvpn-
server1.ooni.io

PLAY [Ensure all hosts are bootstrapped correctly] *****************************
skipping: no hosts matched

PLAY [Deploy monitoring host] **************************************************
skipping: no hosts matched

PLAY [Update monitoring config] ************************************************
skipping: no hosts matched

PLAY [Deploy ooni backend services] ********************************************
skipping: no hosts matched

PLAY [Deploy clickhouse proxy] *************************************************
skipping: no hosts matched

PLAY [Deploy oonidata clickhouse hosts] ****************************************
skipping: no hosts matched

PLAY [Deploy airflow frontend host] ********************************************
skipping: no hosts matched

PLAY [Setup OpenVPN server] ****************************************************
skipping: no hosts matched

PLAY [Deploy notebook host] ****************************************************
skipping: no hosts matched

PLAY RECAP *********************************************************************

Pusher @LDiazN
Action pull_request
Working Directory
Workflow .github/workflows/check_ansible.yml
Last updated Tue, 29 Apr 2025 08:51:56 GMT

Copy link
Member

@hellais hellais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would add the comment mentioned in here and then it's good to go!

@LDiazN LDiazN merged commit 181013b into main Apr 29, 2025
1 of 2 checks passed
@LDiazN LDiazN deleted the fix-circular-dependency-ch-proxy branch April 29, 2025 09:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working correctly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Circular dependency on clickhouse proxy deployment
2 participants