Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature: add command to test the vpn with system privileges #58

Closed
wants to merge 3 commits into from

Conversation

ainghazal
Copy link
Collaborator

Checklist

  • I have read the contribution guidelines
  • Iff you changed code related to services, or inter-service communication, make sure you update the diagrams in ARCHITECTURE.md.
  • Reference issue for this pull request: refactor to use a layered architecture #47

Description

This is a transient command to be able to test the VPN given administrator privileges. It will create a tun interface, setup routes, and move all system traffic over the tun. Useful for testing the current architecture and do performance tests against OpenVPN.

We still need to converge the current legacy binary app, that could take different commands to behave as ping , a socks5 proxy, or just fetch a remote resource over the VPN using gvisor, but we will do that at a later point.

@ainghazal ainghazal changed the title add command to test the vpn with system privileges feature: add command to test the vpn with system privileges Jan 24, 2024
@ainghazal ainghazal self-assigned this Jan 24, 2024
@ainghazal ainghazal requested a review from bassosimone January 24, 2024 16:57
Copy link
Contributor

@bassosimone bassosimone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unclear to me whether we want to merge this or just update the minivpn binary.

@ainghazal
Copy link
Collaborator Author

good question - we should discuss. at this point, I think we can just replace the binary after merging other outstanding PRs. I will update this branch with the latest modifications. the good thing is that the integration test does not depend on the binary interface.

@ainghazal
Copy link
Collaborator Author

closing in favor of #66

@ainghazal ainghazal closed this Feb 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants