Update to latest trunk #28
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ootwch
force-pushed
the
20221105_no_http_host_pr
branch
from
5629e3f
to
7995c19
Compare
Follow up to [59135]. See #62137. git-svn-id: https://develop.svn.wordpress.org/trunk@59137 602fd350-edb4-49c9-b593-d223f7449a82
Add an `h1` heading with the existing `login_header()` text string on each view of the login screen. Mark the existing `h1`, used to wrap the WordPress logo, with `role="presentation"`, to remove it from the headings hierarchy. Props roytanck, joedolson, ryokuhi, sabernhardt, pamprn, nagpai, mukesh27. Fixes #51786. git-svn-id: https://develop.svn.wordpress.org/trunk@59138 602fd350-edb4-49c9-b593-d223f7449a82
Check whether the media frame menu has action items. If not, hide the sidebar. Prevents showing a sidebar that looks interactive but contains no controls that are interactive. When in Create Gallery mode, the only action available is 'Create Gallery', and it is always active. Props ukdrahul, ababir, ruchirj, nhrrob, joedolson, shailu25, mukesh27, sudipatel007, dhrumilk. Fixes #60666. git-svn-id: https://develop.svn.wordpress.org/trunk@59139 602fd350-edb4-49c9-b593-d223f7449a82
This adds tracking of the JPEG XL image type support alongside WebP, HEIC, and AVIF image types when requesting an upgrade from WordPress.org. This will check for JPEG XL support in both ImageMagick and GD, even though GD technically does not yet have support for JPEG XL. Props deepakrohilla, swissspidy, dd32, ayeshrajans, samiamnot, joemcgill. Fixes #62050. git-svn-id: https://develop.svn.wordpress.org/trunk@59140 602fd350-edb4-49c9-b593-d223f7449a82
The most notable change in this update is that all code is now namespaced and uses PSR-4 classes, though there is a compatibility layer available for extenders using the older class names, so plugin or theme authors directly using SimplePie can decide for themselves when they want to change to using the namespaced names for SimplePie classes. Note: This commit includes additional fixes for PHP 8.4 compatibility ([simplepie/simplepie#875 PR 875], [simplepie/simplepie#888 PR 888]) from the `one-dot-eight` branch of SimplePie, which is expected to be [simplepie/simplepie#886 released as SimplePie 1.8.1] soon. References: * [https://github.com/simplepie/simplepie/releases/tag/1.8.0 SimplePie 1.8.0 release notes] * [https://github.com/simplepie/simplepie/releases/tag/1.7.0 SimplePie 1.7.0 release notes] * [https://github.com/simplepie/simplepie/releases/tag/1.6.0 SimplePie 1.6.0 release notes] * [simplepie/simplepie@1.5.8...1.8.0 Full list of changes in SimplePie 1.8.0] Follow-up to [47733], [49176], [52393], [52413]. Props jrf, peterwilsoncc, chaion07, cu121, markparnell, audrasjb, costdev, Presskopp, desrosj, faisal03, mukesh27, SergeyBiryukov. See #55604. git-svn-id: https://develop.svn.wordpress.org/trunk@59141 602fd350-edb4-49c9-b593-d223f7449a82
…zdecode.php`. The file should be named `Gzdecode.php` (with the capital G), to avoid autoloading problems on case-sensitive file systems (*nix). Follow-up to [59141]. Props jrf. See #55604. git-svn-id: https://develop.svn.wordpress.org/trunk@59142 602fd350-edb4-49c9-b593-d223f7449a82
Improve the regular expression for making links clickable to account for parenthesis in links containing an extension, for example: `http://wordpress.org/my-image(2).jpg`. Props coquardcyr, hellofromtonya, parthvataliya, rhellewellgmailcom. Fixes #62037. git-svn-id: https://develop.svn.wordpress.org/trunk@59143 602fd350-edb4-49c9-b593-d223f7449a82
When uploading lossless WebP images, WordPress now correctly outputs lossless WebP with both the Imagick and GD image editors. Props: adamsilverstein, martinkrcho. Fixes #60291. git-svn-id: https://develop.svn.wordpress.org/trunk@59145 602fd350-edb4-49c9-b593-d223f7449a82
It's a new dawn, it's a new day. It's a new default theme for 2025. And I'm feeling good. Props poena, karmatosed, onemaggie, juanfra, garethelwell, joen, beafialho, richtabor, noruzzaman, shailu25, kishanjasani, up1512001, ajlende, huzaifaalmesbah, kafleg, dballari, lastsplash, jennifarhat, amjadr360, rejaulalomkhan, oncecoupled, devmuhib, tanvirul, arkenon, elfu98, erichmond, kardi420, ktaron, melchoyce, maneshtimilsina, jorbin, ritterml, eherman24, vcanales, ikamal, bobbyleenoblestudios, germanfrelo, kraftbj, mcrisp1972, peterwilsoncc, luminuu, eliorivero, jeherve, fac3less, alexandrebuffet. Fixes #62103. git-svn-id: https://develop.svn.wordpress.org/trunk@59146 602fd350-edb4-49c9-b593-d223f7449a82
Right now, for example if DB_COLLATE is defined as '', the value will not be shown in the WordPress Constants list, there's just an empty space. This adds a message so it's clearer when the constant is empty. Props Presskopp, brobken, Clorith. Fixes #58265. git-svn-id: https://develop.svn.wordpress.org/trunk@59147 602fd350-edb4-49c9-b593-d223f7449a82
Syncs `@wordpress/*` packages to the `wp-6.7` npm tag. See #61906. git-svn-id: https://develop.svn.wordpress.org/trunk@59148 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/trunk@59149 602fd350-edb4-49c9-b593-d223f7449a82
Add additional references to the new default theme required in various locations of the code base, build steps and unit tests. Follow up to [59146]. Props afragen, dd32, desrosj, davidbaumwald, jorbin, courane01, kirasong. See #62103. git-svn-id: https://develop.svn.wordpress.org/trunk@59150 602fd350-edb4-49c9-b593-d223f7449a82
Remove TT5 from performance tests as the baseline tests run against an older version of WordPress that do not include all of the functions used in the new theme. Follow up to [59146], [59150]. Props mukesh27. See #62103. git-svn-id: https://develop.svn.wordpress.org/trunk@59151 602fd350-edb4-49c9-b593-d223f7449a82
git-svn-id: https://develop.svn.wordpress.org/trunk@59152 602fd350-edb4-49c9-b593-d223f7449a82
…ings. Follow-up to [62136]. Props swissspidy. Fixes #62149. git-svn-id: https://develop.svn.wordpress.org/trunk@59153 602fd350-edb4-49c9-b593-d223f7449a82
[59083] introduced an issue where Script Modules registered src does not correctly respect the includes path. Before that change, script modules were registered using includes_url. The patch used a hard-coded path which breaks when sites are not served from the root, e.g. the site root is https://example.com/wp instead of https://example.com/. Follow-up to [59083]. Props nendeb55, jonsurrell, cbravobernal. Fixes #62146. git-svn-id: https://develop.svn.wordpress.org/trunk@59154 602fd350-edb4-49c9-b593-d223f7449a82
…YPE` constants. Includes: * Simplifying the logic and bringing some consistency to how the values are checked and displayed. * Correcting the debug value for `DB_COLLATE`. This should be the actual contents of the constant, and empty if it is indeed empty, as the debug data that's copied and shared should represent the raw value, and does not need to be in a user-readable format. Follow-up to [45782], [52021], [54239], [59147]. Props Clorith, SergeyBiryukov. See #58265. git-svn-id: https://develop.svn.wordpress.org/trunk@59155 602fd350-edb4-49c9-b593-d223f7449a82
The change in [59139] caused all media modal menus to disappear. Unprops joedolson. See #60666. git-svn-id: https://develop.svn.wordpress.org/trunk@59156 602fd350-edb4-49c9-b593-d223f7449a82
In [59127], `_doing_it_wrong` warnings were added if plugins or themes load translations too early, either through a manual function call or just-in-time loading. Because many plugins and themes still manually call `load_plugin_textdomain()`, `load_theme_textdomain()` or `load_muplugin_textdomain()`, even though they don't have to anymore, that caused a lot of warnings. With this new approach, these functions merely register the translations path in the existing `WP_Textdomain_Registry` and do not immediately try to load the translations anymore. The loading is all handled by the just-in-time functionality. This way, warnings will only be emitted if triggering the just-in-time loading too early, greatly improving the developer experience and to a degree also performance. Props swissspidy, sergeybiryukov, mukesh27. See #44937. git-svn-id: https://develop.svn.wordpress.org/trunk@59157 602fd350-edb4-49c9-b593-d223f7449a82
* Inline comments must end in full stops, exclamation marks, or question marks. * There must be exactly one blank line after the file comment. Follow-up to [24832], [25023], [25088], [25090], [25213], [51045]. Props pitamdey, dhruvang21, aristath. Fixes #62098. git-svn-id: https://develop.svn.wordpress.org/trunk@59158 602fd350-edb4-49c9-b593-d223f7449a82
Expands the use of `wp_get_wp_version()` to get an unmodified value of the current WordPress version in various locations in which it would be unhelpful if a plugin has modified the global `$wp_version`. This includes: * Theme and plugin compatibility tests * During the upgrade process of WP Core * Debug and site health data reports of the current version * Version number display in the dashboard * Block theme export and caching utilities * The `WPDB` class Props peterwilsoncc, hellofromtonya. See #61627. git-svn-id: https://develop.svn.wordpress.org/trunk@59159 602fd350-edb4-49c9-b593-d223f7449a82
Fix several settings groups in the discussion options that were written in a compound/sentence structure format. These formats are difficult to parse for screen reader users and have significant layout problems in mobile viewports. Change settings to use independent labeling. Props Cheffheid, anthakkar08, DrewAPicture, afercia, jwgoedert, sannevndrmeulen, sudipatel007, tirth03, joedolson. See #31354. git-svn-id: https://develop.svn.wordpress.org/trunk@59160 602fd350-edb4-49c9-b593-d223f7449a82
In [56515], the default value of `Add New` was changed to "Add New Post / Add New Page". This caused problems with post types where `add_new` was not declared. Change core usage to reference the `add_new_item` value and revert the default value of `add_new` back to "Add New / Add New". This retains the accessibility advantages without creating counter intuitive usage of the `add_new` key. With this change, post types registered with no `add_new` key will be unimpacted in core, and post types registered with no `add_new_item` key will use the default "Add New Post", which is not a change from the current state. Props smerriman, afercia, rcreators, joedolson, eclev91, johnbillion. Fixes #60045. git-svn-id: https://develop.svn.wordpress.org/trunk@59161 602fd350-edb4-49c9-b593-d223f7449a82
Props pbearne, rajinsharwar, jorbin, mukesh27, aristath, desrosj, ironprogrammer. Fixes #60389. git-svn-id: https://develop.svn.wordpress.org/trunk@59162 602fd350-edb4-49c9-b593-d223f7449a82
…d_target()` tests. Includes: * Correcting the test class name as per the naming conventions. * Documenting data provider values using hash notation. * Passing the `$attrs` parameter to the function if not `null`. Follow-up to [26328], [55563], [59162]. See #61530. git-svn-id: https://develop.svn.wordpress.org/trunk@59163 602fd350-edb4-49c9-b593-d223f7449a82
In ongoing work to modularize the `WP_Debug_Data` class, several methods were added with `public` visibility. This patch sets the new methods to `private` as a measure to ensure optionality as the changes progress, since it's easier to move from private to public than the other way around. Developed in #7482 Discussed in https://core.trac.wordpress.org/ticket/61648 Follow-up to [58830], [58855], [58964], [59002], [59011], [59060], [59100]. Props apermo, jonsurrell. Fixes #61648. git-svn-id: https://develop.svn.wordpress.org/trunk@59164 602fd350-edb4-49c9-b593-d223f7449a82
…dd_base_url()`. Follow-up to [8540], [32590], [46596]. See #61608. git-svn-id: https://develop.svn.wordpress.org/trunk@59165 602fd350-edb4-49c9-b593-d223f7449a82
This commits some minor changes made when running `composer format`. Follow up to [58975], [59011], [59115]. See #61103, #62014, #61648. git-svn-id: https://develop.svn.wordpress.org/trunk@59166 602fd350-edb4-49c9-b593-d223f7449a82
…pporting browsers. Based on the user agent stylesheet rules outlined in https://html.spec.whatwg.org/multipage/rendering.html#img-contain-size, images that have `sizes=auto` while applying `width: auto` or `width: fit-content` would be constrained to only 300px width. This changeset overrides said user agent stylesheet rule with a much larger constraint, to avoid the problem. Additionally, it introduces a filter `wp_img_tag_add_auto_sizes` which can be used to opt out of the functionality, as an additional measure. Props joemcgill, flixos90, dooperweb, SirLouen, azaozz, mukesh27, apermo. Fixes #62413. See #61847, #62345. git-svn-id: https://develop.svn.wordpress.org/trunk@59415 602fd350-edb4-49c9-b593-d223f7449a82
…outer Remove the workaround for a bug that was fixed in WordPress/gutenberg#66183. Previously, if the store was not initialized with a minimal navigation object, the interactivity-router script module would error. Props jonsurrell, czapla, gziolo. Fixes 62465#. git-svn-id: https://develop.svn.wordpress.org/trunk@59416 602fd350-edb4-49c9-b593-d223f7449a82
Follow-up to [56515]. Props timse201. Fixes #62458. git-svn-id: https://develop.svn.wordpress.org/trunk@59417 602fd350-edb4-49c9-b593-d223f7449a82
…_block_nodes An `$include_node_paths_only` option to `get_block_nodes()` was introduced to improve performance. When set to `true`, this option tells the function to only return paths, and not selectors, for consumers that only needed paths to style values. For one of the conditional blocks, block style variations wasn't included. This commit adds them to the array of paths following the existing model `$node[]['path' => [], 'variations' => ['path' => []]]`. Follow-up to [61858]. Props aaronrobertshaw, ramonopoly. Fixes #62399. git-svn-id: https://develop.svn.wordpress.org/trunk@59418 602fd350-edb4-49c9-b593-d223f7449a82
…heme. In the Modern color scheme, the font color on hover in the admin bar is bright green. However, in the WordPress.org site itself, the color used is Blueberry 2. This commits aligns both colors on the more balanced Blueberry color. Props fushar, Joen. Fixes #62219. git-svn-id: https://develop.svn.wordpress.org/trunk@59419 602fd350-edb4-49c9-b593-d223f7449a82
The HTML API `::next_tag` method now performs case-insensitive matching when searching for tags by name. For example, searching for 'DIV' will match both '<div>' and '<DIV>' tags. Props jonsurrell, dmsnell. Fixes #62427. git-svn-id: https://develop.svn.wordpress.org/trunk@59422 602fd350-edb4-49c9-b593-d223f7449a82
In [59138], the login screens were updated to change the `h1` heading from the logo to screen-reader hidden text. Along with that HTML change, we changed the CSS selectors from `.login h1` to `.login .wp-login-logo`. This unnecessary change increased specificity and broke the CSS selectors used by a wide variety of plugins to replace the login logo. Commit reverts the change in selector back to using the `.login h1` pattern. Props leecollings, sabernhardt, im3dabasia1, roytanck, sailpete, joedolson. Fixes #62410. git-svn-id: https://develop.svn.wordpress.org/trunk@59424 602fd350-edb4-49c9-b593-d223f7449a82
The Learn WordPress website is supposed to automatically redirect to the correct locale according to the browser's language settings, however that may not work as expected in some cases. This commit brings consistency with the other WordPress.org links, which can be localized as appropriate. Follow-up to [56720]. Props timse201, ruturajraval2305, yogeshbhutkar, ajayghaghretiya-multidots, swissspidy, sabernhardt, im3dabasia1, mukesh27. Fixes #62459. git-svn-id: https://develop.svn.wordpress.org/trunk@59425 602fd350-edb4-49c9-b593-d223f7449a82
Wrap three untranslatable strings in nav menus in JS translation functions. Follow up to [59265]. Props juliemoynat, swissspidy, yogeshbhutkar, sergeybiryukov, desrosj, tobifjellner, audrasjb, joedolson. Fixes #62402. git-svn-id: https://develop.svn.wordpress.org/trunk@59426 602fd350-edb4-49c9-b593-d223f7449a82
Improvements were made in 6.7 to ensure that salts stored in the database were primed more efficiently. The logic added to accomplish this suffered from an edge case where array indexes were unexpectedly missing when `wp_salt()` was called recursively. Follow up to [58837]. Props juliobox, ankitkumarshah, dilipbheda, johnbillion, joemcgill, desrosj. Fixes #62424. git-svn-id: https://develop.svn.wordpress.org/trunk@59427 602fd350-edb4-49c9-b593-d223f7449a82
When `load_*_textdomain()` functions are called after WordPress has already attempted just-in-time loading of translations, nothing happens. This updates the related logic to retry translation loading when a custom path is set to ensure all translations are available. Additionally, this also fixes cases where an `en_US.mo` file is provided with non-English strings to override the default language. Follow up to [59157]. Props swissspidy, peterwilsoncc, desrosj, apermo, sergeybiryukov, wildworks, tigriweb, twvania, looswebstudio, stimul, audrasjb, finntown, bluantinoo, timwhitlock, albigdd. See #62337. git-svn-id: https://develop.svn.wordpress.org/trunk@59430 602fd350-edb4-49c9-b593-d223f7449a82
Includes: * Moving the comments directly above `wp.i18n._x()` so that they can be picked up properly. * Simplifying the context to avoid unnecessarily translating the string twice for the same use case. * Using the established translator comments format for consistency. Follow-up to [59428]. See #62402. git-svn-id: https://develop.svn.wordpress.org/trunk@59431 602fd350-edb4-49c9-b593-d223f7449a82
Syncs Editor packages for WordPress 6.7.1 RC1. Includes the following PRs: - WordPress/gutenberg#66945 - WordPress/gutenberg#66889 - WordPress/gutenberg#67139 Reviewed by desrosj. Merges [59437] to trunk. Props mmaattiiaass, ramonopoly, mamaduka, get_dave, poena, ntsekouras, mcsf, jsnajdr, 0mirka00, desrosj, joemcgill, cbravobernal, azaozz, room34, mayanktripathi32, im3dabasia1, jonsurrell. Fixes #62478, #62447. git-svn-id: https://develop.svn.wordpress.org/trunk@59438 602fd350-edb4-49c9-b593-d223f7449a82
This updates the conditions added in [59370] to skip unnecessary pull request comments when Dependabot is the opening contributor to check for the correct `github.actor` value. Follow up to [59380]. See #62221. git-svn-id: https://develop.svn.wordpress.org/trunk@59441 602fd350-edb4-49c9-b593-d223f7449a82
…_styles(). This adds an `! empty()` check for classnames and declarations to avoid calling array_merge() with an empty value. Props mukesh27, ramonopoly, aaronrobertshaw. Fixes #62317. git-svn-id: https://develop.svn.wordpress.org/trunk@59442 602fd350-edb4-49c9-b593-d223f7449a82
…ji fails. This allows the full error message to be shown from the connection attempt instead of a generic error message. Fixes #62382 git-svn-id: https://develop.svn.wordpress.org/trunk@59443 602fd350-edb4-49c9-b593-d223f7449a82
HTML Fragment parsing always happens with a context node, which may impact how a fragment of HTML is parsed. HTML Fragment Processors can be instantiated with a `BODY` context node via `WP_HTML_Processor::create_fragment( $html )`. This changeset adds a static method called `create_fragment_at_current_node( string $html_fragment )`. It can only be called when the processor is paused at a `#tag`, with some additional constraints: - The opening and closing tags must appear in the HTML input (no virtual tokens). - No "self-contained" elements are allowed ( `IFRAME`, `SCRIPT`, `TITLE`, etc.). If successful, the method will return a `WP_HTML_Processor` instance whose context is inherited from the node that the method was called from. Props jonsurrell, bernhard-reiter, gziolo. Fixes #62357. git-svn-id: https://develop.svn.wordpress.org/trunk@59444 602fd350-edb4-49c9-b593-d223f7449a82
Each theme’s `theme.json` schema version should be pinned to the version that was valid at the time it was released. Props im3dabasia1, poena, mukesh27. Fixes #62455. git-svn-id: https://develop.svn.wordpress.org/trunk@59448 602fd350-edb4-49c9-b593-d223f7449a82
Adds a new function, `wp_render_empty_block_template_warning`, that renders a warning for logged-in users when a block template is empty. Reviewed by get_dave, richtabor. Props vcanales, mikachan, peterwilsoncc, richtabor, get_dave, mrfoxtalbot, matveb, arielmaidana, seifradwane, annezazu. Fixes #62053. git-svn-id: https://develop.svn.wordpress.org/trunk@59449 602fd350-edb4-49c9-b593-d223f7449a82
Prevent fragments from being created at tag closers. Follow-up to [59444]. Props jonsurrell, bernhard-reiter. Fixes #62357. git-svn-id: https://develop.svn.wordpress.org/trunk@59450 602fd350-edb4-49c9-b593-d223f7449a82
All JSON files in the theme should be pinned to the appropriate schema version, not just `theme.json`. Follow up to [59448]. Props im3dabasia1, poena. Fixes #62455. git-svn-id: https://develop.svn.wordpress.org/trunk@59451 602fd350-edb4-49c9-b593-d223f7449a82
…ort-*.json` files. This extracts the logic responsible for parsing the `.version-support-*.json` files and returning a list of supported PHP and MySQL versions for a given branch of WordPress into a reusable workflow so that other workflows can make use of the functionality without repeating code. See #62221. git-svn-id: https://develop.svn.wordpress.org/trunk@59452 602fd350-edb4-49c9-b593-d223f7449a82
This addresses two instances where a function that is documented as returning `{someType}|null` doesn't explicitly return `null`.
Affected functions:
* `array_key_first()`
* `WP_REST_Posts_Controller::handle_terms()`
Follow-up to [38832], [52038].
Props justlevine.
See #52217.
git-svn-id: https://develop.svn.wordpress.org/trunk@59453 602fd350-edb4-49c9-b593-d223f7449a82
…licking on a Category checkbox on the old Edit Post screen. Props ffffelix, desrosj, ironprogrammer, neotrope, narenin, zaoyao, im3dabasia1, cbravobernal, azaozz. Fixes #62504. git-svn-id: https://develop.svn.wordpress.org/trunk@59454 602fd350-edb4-49c9-b593-d223f7449a82
…svg()`. This updates `WP_Theme_JSON::get_svg_filters()` to use `WP_Duotone::get_filter_svg_from_preset()` instead of the `wp_get_duotone_filter_svg()` function, deprecated in WordPress 6.3. Follow-up to [52757], [56101]. Props justlevine. See #52217. git-svn-id: https://develop.svn.wordpress.org/trunk@59455 602fd350-edb4-49c9-b593-d223f7449a82
…est()`. `$args` is defined in the immediately preceding code block, and only contains non-integer keys, so there is never an `$args[0]` to unset. Follow-up to [44933]. Props justlevine. See #52217. git-svn-id: https://develop.svn.wordpress.org/trunk@59456 602fd350-edb4-49c9-b593-d223f7449a82
…is a query string. Follow-up to [51648], see #51636. Props antonvlasenko, swissspidy, spacedmonkey. Fixes #57048. git-svn-id: https://develop.svn.wordpress.org/trunk@59457 602fd350-edb4-49c9-b593-d223f7449a82
It is possible to supply a set of default query `args` to `register_taxonomy()` which will be used when querying a list of terms -- for example, `orderby` in order to specify how the resulting list of terms should be sorted. The Terms REST API controller previously respected these default query args only if the request included a post ID. This changeset makes it so that the default args will also be respected if no post ID is provided. Props bernhard-reiter, jsnajdr. Fixes #62500. git-svn-id: https://develop.svn.wordpress.org/trunk@59458 602fd350-edb4-49c9-b593-d223f7449a82
.jpg`){kind=link}
…cookie()`. This resolves an issue where the string `$expired` value is used both in a comparison and addition with integer values. Follow-up to [6387], [28424], [45590]. Props justlevine. See #52217. git-svn-id: https://develop.svn.wordpress.org/trunk@59459 602fd350-edb4-49c9-b593-d223f7449a82
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update to latest trunk