Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(94): fix formatting to be compliant with XMLBuilder #180

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mdovhopo
Copy link

@mdovhopo mdovhopo commented May 2, 2024

Please include a summary of the change and which issue is fixed. Fixes # (issue number)

Type of change:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation update

This PR should fix previously reported issue #94 that i also encountered. current pretty print in XMLBuilderCB prints values on separate lines like:

<Root>
   <Test>
   value
   </Test>
</Root>

but it should be

<Root>
   <Test>value</Test>
</Root>

the main problem is that pretty printed xml in that way may not pass xsd validation, because printer adds spaces and '\n's.

This might be a naive approach, so i would appreciate review from codeowner

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant