go-logging: provide right pc to runtime.FuncForPC #133
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We want a PC in the call instruction, not the PC of the instruction just after the call instruction. (A more robust fix would be to move to runtime.CallersFrames, as runtime.Callers+runtime.FuncForPC is deprecated.) This updates go-logging so it works with the mid-stack inlining coming with go 1.12.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We want a PC in the call instruction, not the PC of the instruction
just after the call instruction.
(A more robust fix would be to move to runtime.CallersFrames, as
runtime.Callers+runtime.FuncForPC is deprecated.)
This updates go-logging so it works with the mid-stack inlining coming
with go 1.12.