pyatls: consider clock skew, add logging, version 0.0.5 #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
HernanGatta
changed the title
HernanGatta
changed the title
🦙 MegaLinter status: ✅ SUCCESS
See detailed report in MegaLinter reports You could have the same capabilities but better runtime performances if you use a MegaLinter flavor:
MegaLinter is graciously provided by |
octaviansima
approved these changes
May 24, 2024
| pub = peer_cert.public_key() | ||
|
|
||
| logging.debug("Fetching certificate SubjectPublicKeyInfo") |
There was a problem hiding this comment.
Let's standardize these logs a bit more -- e.g., use ... here and above or remove it as part of "Fetching certificate extension value..." and similar
HernanGatta
force-pushed
the
hegatta/clock-skew-and-logging
branch
from
35ac376
to
5f9750f
Compare
When issues occur during aTLS connection establishment, it is unclear what the problem is, since there is currently no logging. With this change, one may write in the calling package: logging.basicConfig() logging.getLogger().setLevel(logging.DEBUG) and see useful logging as connections are established.
HernanGatta
force-pushed
the
hegatta/clock-skew-and-logging
branch
from
5f9750f
to
a4af059
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Clock Skew and Logging
Note: Commits can be reviewed independently.
When validating JWT tokens, the PyJWT package validates the
IAT(Issued At) claim strictly: it must be exactly less than the time now. This requires the issuing service and the validating system to have synchronized clocks. Otherwise, even a few milliseconds of skew forwards on the service or backwards in the validator can cause the library to claim that a token was issued in the future.There is much discussion in that library as to whether verifying that IAT is strictly in the past is a good idea, particularly since the JWT specification does not state that one must do so.
This PR adds a 5s leeway to time validation to account for this. This PR also adds optional logging so that issues like this can be more easily discovered.