Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor rerank tei #1082

Merged
merged 9 commits into from
Dec 27, 2024
Merged

Refactor rerank tei #1082

merged 9 commits into from
Dec 27, 2024

Conversation

WenjiaoYue
Copy link
Collaborator

@WenjiaoYue WenjiaoYue commented Dec 26, 2024

Description

Refactor the TEI-related part in rerank.

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

no

Tests

CI pass.

WenjiaoYue added 2 commits December 26, 2024 23:04
Signed-off-by: WenjiaoYue <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>
@WenjiaoYue WenjiaoYue changed the base branch from main to refactor_comps December 26, 2024 15:46
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

WenjiaoYue and others added 3 commits December 26, 2024 23:57
Signed-off-by: WenjiaoYue <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>
Copy link
Collaborator

@letonghan letonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@chensuyue chensuyue merged commit 64c547e into refactor_comps Dec 27, 2024
12 checks passed
@chensuyue chensuyue deleted the wenjiao/rerank_tei_refactor branch December 27, 2024 04:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants