Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Megaservice / orchestrator metric testing + fixes #1348

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

eero-t
Copy link
Contributor

@eero-t eero-t commented Feb 28, 2025

Description

Adds test code for orchestrator.py metrics, and fixes for bugs revealed by the test code.

Issues

  • First token count was wrong in some situations
  • CI does not verify that orchestrator actually processed all tokens
  • CI was missing tests for orchestrator metrics

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • Others (added test code)

Dependencies

n/a

Tests

  • Manual testing with ChatQnA, on top of working (earlier) GenAIComps code
  • New CI test

@eero-t eero-t force-pushed the metric-test branch 2 times, most recently from be19c98 to 1ad8db3 Compare March 3, 2025 18:42
Copy link

codecov bot commented Mar 3, 2025

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comps/cores/mega/orchestrator.py 66.66% 1 Missing ⚠️
Files with missing lines Coverage Δ
comps/cores/mega/orchestrator.py 90.87% <66.66%> (-0.35%) ⬇️

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant