Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return Mega/Micro Service Version number at runtime #912

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

louie-tsai
Copy link
Collaborator

@louie-tsai louie-tsai commented Nov 18, 2024

Description

For those running Mega/Micro Service, users might need to understand its version for debugging or runtime issues.
Therefore, add a method to get version number at runtime

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

NA

Tests

Manually test on AWS Xeon instance

Copy link

codecov bot commented Nov 18, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
comps/cores/mega/http_service.py 0.00% 2 Missing ⚠️
Files with missing lines Coverage Δ
comps/cores/mega/http_service.py 76.71% <0.00%> (-1.07%) ⬇️

@louie-tsai
Copy link
Collaborator Author

@chensuyue could you take a look for the PR?

@chensuyue
Copy link
Collaborator

@lvliang-intel please review.

@louie-tsai
Copy link
Collaborator Author

@lvliang-intel please review.

@lvliang-intel Could you help to check the PR?

Signed-off-by: Tsai, Louie <[email protected]>

fix

Signed-off-by: Tsai, Louie <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants