Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added compose example for MultimodalQnA deployment on AMD ROCm systems #1233

Conversation

artem-astafev
Copy link
Contributor

Description

Changes for MultimodalQnA example deployment to AMD ROCm systems.

Type of change

  • Added compose example for MultimodalQnA deployment on AMD ROCm systems.
  • Added Readme file for MultimodalQnA compose deployment example on AMD ROCm systems.
  • Added CI tests for MultimodalQnA compose deployment example on AMD ROCm systems.

Tests

For manual test s go to GenAIExamples/MultimodalQnA/tests dir and run test_compose_on_rocm.sh script (./test_compose_on_rocm.sh)

@artem-astafev artem-astafev force-pushed the feature/MultimodalQnA-add-compos-example-for-amd-rocm branch from 15ea852 to 95f9b07 Compare December 6, 2024 08:40
Copy link
Collaborator

@letonghan letonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @artem-astafev , thanks for your contribution.
Please check the comment here and refine the set_env part in your readme.

MultimodalQnA/docker_compose/amd/gpu/rocm/README.md Outdated Show resolved Hide resolved
@artem-astafev
Copy link
Contributor Author

artem-astafev commented Dec 13, 2024

Hi @artem-astafev , thanks for your contribution. Please check the comment here and refine the set_env part in your readme.

Hi @letonghan , I've removed manual environment set part and add set_env.sh description in Readme.md in last 2 commits(c7291ce and 0ecb8b5).

I can't get what else can be change in Readme.md for better description. Is these enough or something else need to be changed ?

@artem-astafev
Copy link
Contributor Author

CI Tests starts to fail because of backend microservice could start with error:

File "/home/user/multimodalqna.py", line 10, in <module> from comps import Gateway, MegaServiceEndpoint, MicroService, ServiceOrchestrator, ServiceType ImportError: cannot import name 'Gateway' from 'comps' (/home/user/GenAIComps/comps/__init__.py)

Probably because of opea-project/GenAIComps#979 merge.

Copy link

github-actions bot commented Dec 17, 2024

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

@artem-astafev artem-astafev force-pushed the feature/MultimodalQnA-add-compos-example-for-amd-rocm branch from 7573f4a to a4ef17c Compare December 18, 2024 09:16
Copy link
Collaborator

@letonghan letonghan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@letonghan letonghan merged commit 236ea6b into opea-project:main Dec 18, 2024
14 checks passed
chyundunovDatamonsters pushed a commit to chyundunovDatamonsters/OPEA-GenAIExamples that referenced this pull request Dec 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants