Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor Retrievers related Examples #1387

Merged
merged 18 commits into from
Jan 16, 2025
Merged

Refactor Retrievers related Examples #1387

merged 18 commits into from
Jan 16, 2025

Conversation

letonghan
Copy link
Collaborator

Description

Delete redundant retrievers docker image in docker_images_list.md.
Refactor Retrievers related Examples READMEs.
Change all of the comps/retrievers/xxx/xxx/Dockerfile path into comps/retrievers/src/Dockerfile.

Issues

Fix the Examples CI issues of PR opea-project/GenAIComps#1138.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Others (enhancement, documentation, validation, etc.)

Dependencies

None

Tests

None

Copy link

github-actions bot commented Jan 14, 2025

Dependency Review

✅ No vulnerabilities or license issues found.

Scanned Files

@letonghan
Copy link
Collaborator Author

Need to be merged after this pr merged: opea-project/GenAIComps#1138

@chensuyue
Copy link
Collaborator

Need to update image build path in test code and test with 1138

@letonghan letonghan changed the title Refactor Retrievers related Examples READMEs Refactor Retrievers related Examples Jan 15, 2025
@lianhao
Copy link
Collaborator

lianhao commented Jan 16, 2025

Should this be changed with the new dataprep at the same time? Because I see the new retriever is not compatible with the old dataprep, the default INDEX_NAME and/or COLLECTION_NAME are different for Redis/Milvus between the old and new image respectively, thus files uploaded by old dataprep image can NOT be retrieved by new retriever.

@letonghan
Copy link
Collaborator Author

Should this be changed with the new dataprep at the same time? Because I see the new retriever is not compatible with the old dataprep, the default INDEX_NAME and/or COLLECTION_NAME are different for Redis/Milvus between the old and new image respectively, thus files uploaded by old dataprep image can NOT be retrieved by new retriever.

@lianhao Thanks for your comment.
Yes, the refactor for dataprep component is in this pr, which will also be merged before the v1.2 release.

Also, I've checked the default INDEX_NAME/COLLECTION_NAME for the new version of retrievers and dataprep.
The INDEX_NAME of Redis is rag_redis and the COLLECTION_NAME of Milvus is rag_milvus, which IS consistent between retrievers and dataprep. (commit link here)

Since the retrievers and dataprep components will be refactored together, the old versions will be discarded.
Please let me know if you have further questions!

Revert CI related branch settings for merge.
This reverts commit 421fa6d.
@chensuyue chensuyue merged commit 4cabd55 into main Jan 16, 2025
27 of 46 checks passed
@chensuyue chensuyue deleted the retrievers_related branch January 16, 2025 06:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants