-
Notifications
You must be signed in to change notification settings - Fork 212
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor Retrievers related Examples #1387
Conversation
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Dependency Review✅ No vulnerabilities or license issues found.Scanned Files |
for more information, see https://pre-commit.ci
Need to be merged after this pr merged: opea-project/GenAIComps#1138 |
Need to update image build path in test code and test with 1138 |
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
…GenAIExamples into retrievers_related
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Signed-off-by: letonghan <[email protected]>
Should this be changed with the new dataprep at the same time? Because I see the new retriever is not compatible with the old dataprep, the default INDEX_NAME and/or COLLECTION_NAME are different for Redis/Milvus between the old and new image respectively, thus files uploaded by old dataprep image can NOT be retrieved by new retriever. |
@lianhao Thanks for your comment. Also, I've checked the default INDEX_NAME/COLLECTION_NAME for the new version of retrievers and dataprep. Since the retrievers and dataprep components will be refactored together, the old versions will be discarded. |
Revert CI related branch settings for merge. This reverts commit 421fa6d.
Description
Delete redundant retrievers docker image in
docker_images_list.md
.Refactor Retrievers related Examples READMEs.
Change all of the
comps/retrievers/xxx/xxx/Dockerfile
path intocomps/retrievers/src/Dockerfile
.Issues
Fix the Examples CI issues of PR opea-project/GenAIComps#1138.
Type of change
List the type of change like below. Please delete options that are not relevant.
Dependencies
None
Tests
None