Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Agent ui #1389

Merged
merged 8 commits into from
Jan 16, 2025
Merged

Agent ui #1389

merged 8 commits into from
Jan 16, 2025

Conversation

WenjiaoYue
Copy link
Collaborator

@WenjiaoYue WenjiaoYue commented Jan 14, 2025 •
edited
Loading

Description

Add AgentQnA UI code

Integrate the AgentQnA UI code, along with an updated README specific to the UI, a Dockerfile for deployment, and the necessary startup scripts.

Issues

n/a.

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)
  • Others (enhancement, documentation, validation, etc.)

Dependencies

no

Tests

npm run dev

@github-actions GitHub Actions
Copy link

github-actions bot commented Jan 14, 2025 •
edited
Loading

Dependency Review

The following issues were found:
  • ✅ 0 vulnerable package(s)
  • ✅ 0 package(s) with incompatible licenses
  • ✅ 0 package(s) with invalid SPDX license definitions
  • ⚠️ 2 package(s) with unknown licenses.
See the Details below.

License Issues

AgentQnA/ui/svelte/package.json

PackageVersionLicenseIssue Type
marked^15.0.0NullUnknown License
sjcl^1.0.8NullUnknown License

Scanned Files

  • AgentQnA/ui/svelte/package.json

github-advanced-security[bot]
github-advanced-security bot found potential problems Jan 14, 2025
View reviewed changes
AgentQnA/ui/svelte/src/app.html Fixed Show fixed Hide fixed
AgentQnA/ui/svelte/src/app.html Fixed Show fixed Hide fixed
@lkk12014402 lkk12014402 added this to the v1.2 milestone Jan 14, 2025
@lkk12014402
Copy link
Collaborator

#1236

The UI is only for the ChatCompletion API and the first version is in the non-streaming form

@lkk12014402
Copy link
Collaborator

Please update the ui usage into the readme.

minmin-intel
minmin-intel reviewed Jan 14, 2025
View reviewed changes
Copy link
Collaborator

@minmin-intel minmin-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do we choose svelte? It seems that streamlit and gradio are more popular in ecosystem

@minmin-intel
Copy link
Collaborator

Also, there a couple of warnings for the UI code...Should we address those? @lkk12014402 @WenjiaoYue

@WenjiaoYue
Copy link
Collaborator Author

Please update the ui usage into the readme.

Updated UI readme.

@WenjiaoYue
Copy link
Collaborator Author

Why do we choose svelte? It seems that streamlit and gradio are more popular in ecosystem
Streamlit and Gradio are both simpler and quicker, but they have limited flexibility and customization capabilities; Svelte is a web development front-end framework, suitable for highly customized web development, offering better extensibility and flexibility for future growth.

@WenjiaoYue
Copy link
Collaborator Author

Also, there a couple of warnings for the UI code...Should we address those? @lkk12014402 @WenjiaoYue

Yes, the warning has been resolved.

@lkk12014402
Copy link
Collaborator

lkk12014402 commented Jan 15, 2025 •
edited
Loading

Why do we choose svelte? It seems that streamlit and gradio are more popular in ecosystem
Streamlit and Gradio are both simpler and quicker, but they have limited flexibility and customization capabilities; Svelte is a web development front-end framework, suitable for highly customized web development, offering better extensibility and flexibility for future growth.

Additionally:

  1. gradio's underlying front-end framework is svelte
  2. all the GenAIExamples use svelte front-end framework

minmin-intel
minmin-intel reviewed Jan 15, 2025
View reviewed changes
Copy link
Collaborator

@minmin-intel minmin-intel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to add a launch script for launching UI container? Also, can you add a few lines of instructions in readme on how to launch UI? @WenjiaoYue @lkk12014402

@WenjiaoYue
Copy link
Collaborator Author

Do we need to add a launch script for launching UI container? Also, can you add a few lines of instructions in readme on how to launch UI? @WenjiaoYue @lkk12014402

Yes, I have added the command to launch the frontend service with a Docker container in the README.

Add AgentQnA UI code
73b53ee 
Integrate the AgentQnA UI code, along with an updated README specific to the UI, a Dockerfile for deployment, and the necessary startup scripts.

Signed-off-by: WenjiaoYue <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>
@minmin-intel
Copy link
Collaborator

Do we need to add a launch script for launching UI container? Also, can you add a few lines of instructions in readme on how to launch UI? @WenjiaoYue @lkk12014402

Yes, I have added the command to launch the frontend service with a Docker container in the README.

@WenjiaoYue Sorry I don't see the commands...

@WenjiaoYue
Copy link
Collaborator Author

Do we need to add a launch script for launching UI container? Also, can you add a few lines of instructions in readme on how to launch UI? @WenjiaoYue @lkk12014402

Yes, I have added the command to launch the frontend service with a Docker container in the README.

@WenjiaoYue Sorry I don't see the commands...

The README of the UI describes two ways to start the frontend: one is by running the local command npm run dev, and the other is by using Docker.

image

@minmin-intel
Copy link
Collaborator

Do we need to add a launch script for launching UI container? Also, can you add a few lines of instructions in readme on how to launch UI? @WenjiaoYue @lkk12014402

Yes, I have added the command to launch the frontend service with a Docker container in the README.

@WenjiaoYue Sorry I don't see the commands...

The README of the UI describes two ways to start the frontend: one is by running the local command npm run dev, and the other is by using Docker.

image

Thanks for pointing it out. I was looking in the main readme. Can you please add instructions in the main README for UI. Maybe a sentence that links to the README in the UI folder. Thanks! @WenjiaoYue

@WenjiaoYue
Copy link
Collaborator Author

Do we need to add a launch script for launching UI container? Also, can you add a few lines of instructions in readme on how to launch UI? @WenjiaoYue @lkk12014402

Yes, I have added the command to launch the frontend service with a Docker container in the README.

@WenjiaoYue Sorry I don't see the commands...

The README of the UI describes two ways to start the frontend: one is by running the local command npm run dev, and the other is by using Docker.
image

Thanks for pointing it out. I was looking in the main readme. Can you please add instructions in the main README for UI. Maybe a sentence that links to the README in the UI folder. Thanks! @WenjiaoYue
ok, I have added.

@lkk12014402 lkk12014402 merged commit 3a9a24a into main Jan 16, 2025
20 checks passed
@lkk12014402 lkk12014402 deleted the wenjiao/agent_ui branch January 16, 2025 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ZePan110 ZePan110 ZePan110 approved these changes

@lkk12014402 lkk12014402 lkk12014402 approved these changes

@chensuyue chensuyue Awaiting requested review from chensuyue

@minmin-intel minmin-intel Awaiting requested review from minmin-intel minmin-intel is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
v1.2
Development

Successfully merging this pull request may close these issues.
4 participants
@WenjiaoYue @lkk12014402 @minmin-intel @ZePan110