Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorg folder #382

Closed
wants to merge 9 commits into from
Closed

reorg folder #382

wants to merge 9 commits into from

Conversation

kevinintel
Copy link
Collaborator

Description

reorg folder to support different vendors

Issues

n/a

Type of change

List the type of change like below. Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • [Y] New feature (non-breaking change which adds new functionality)
  • Breaking change (fix or feature that would break existing design and interface)

Dependencies

n/a

Tests

CI

@lianhao
Copy link
Collaborator

lianhao commented Sep 3, 2024

I see lots of CI testing is missing in this PR. We need to change the CI related things first, than submit this patch to make sure the changes are covered by CI.

Also we need to update the update_manifests.sh too.

@lianhao
Copy link
Collaborator

lianhao commented Sep 4, 2024

helm chart must have a values.yaml. And this PR seems break our existing CI to skip quite some Gaudi tests.

@kevinintel kevinintel closed this Sep 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants