Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update versions in Helm charts and GMC manifests to v1.1 #609

Closed
wants to merge 1 commit into from

Conversation

eero-t
Copy link
Contributor

@eero-t eero-t commented Nov 25, 2024

Description

Change labels & chart version to match / reduce diff to v1.1 release after c0a3121.

(Needing to do this manually in main branch seems odd. IMHO bot should do this update to main at the same time it updates these, and image tags, in release branch.)

Issues

n/a.

Type of change

  • Bug fix (non-breaking change which fixes an issue)

Dependencies

n/a.

Tests

Should already have been tested as part of v1.1rc branch?

To match / reduce diff to v1.1 release after
c0a3121.

Signed-off-by: Eero Tamminen <[email protected]>
@eero-t eero-t changed the title Update version strings in Helm charts and GMC manifests to v1.1 Update versions in Helm charts and GMC manifests to v1.1 Nov 25, 2024
@eero-t
Copy link
Contributor Author

eero-t commented Nov 25, 2024

Note: PR #587 would update these to 0-latest instead of 1.1.0.

@eero-t
Copy link
Contributor Author

eero-t commented Nov 25, 2024

There are several CI errors. They do not seem to be related to changes from this PR, but to be bugs either in existing code, or CI.

Error: no repository definition for [https://zilliztech.github.io/milvus-helm/.](https://zilliztech.github.io/milvus-helm/) Please add the missing repos via 'helm repo add'

=> Why NeuralBot release changes are not checked / do not need to pass CI: c0a3121 ?

 Traceback (most recent call last):
  File "/home/user/comps/tts/speecht5/dependency/speecht5_server.py", line 15, in <module>
    from comps import CustomLogger
  File "/home/user/comps/__init__.py", line 7, in <module>
    from comps.cores.proto.docarray import (
  File "/home/user/comps/cores/proto/docarray.py", line 10, in <module>
    from pydantic import Field, conint, conlist, field_validator
ImportError: cannot import name 'field_validator' from 'pydantic' (/usr/local/lib/python3.10/dist-packages/pydantic/__init__.cpython-310-x86_64-linux-gnu.so)

=> CI is not using correct latest tag (should be fixed after PR #587 is merged):

I see in CI logs also these:

kubectl get pods -n opea-app-audioqa -l app=router-service -o 'jsonpath={.items[].status.conditions[?(@.type=="Ready")].status}'
error: error executing jsonpath "{.items[].status.conditions[?(@.type==\"Ready\")].status}": Error executing template: array index out of bounds: index 0, length 0. Printing more information for debugging the template:
	template was:
		{.items[].status.conditions[?(@.type=="Ready")].status}
	object given to jsonpath engine was:
		map[string]interface {}{"apiVersion":"v1", "items":[]interface {}{}, "kind":"List", "metadata":map[string]interface {}{"resourceVersion":""}}

@eero-t
Copy link
Contributor Author

eero-t commented Dec 10, 2024

Closing, (already merged) PR #587 replaces this.

@eero-t eero-t closed this Dec 10, 2024
@eero-t eero-t deleted the update-version branch December 10, 2024 09:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant