HPA enabling usability improvement #770
Open
+13
−6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Eero Tamminen <[email protected]>
Generalized inferencing engine references now that that there are more alternatives, and default ones have changed. Signed-off-by: Eero Tamminen <[email protected]>
|
@lianhao ChatQnA fails in CI, but failures are not related to changes in this PR. Any ideas? |
|
issue #773 created to track this. I can reproduced the failure locally both on cpu/gaudi environment, I don't know why the CI succeed in cpu environment. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
monitoringautomatically inhpa-values.yamlIssues
n/a.Type of change
n/a.Dependencies
n/a.Tests
Verified that the Helm generated manifests with the updated
hpa-values.yamlare identical to ones generated earlier with--set global.monitoring=trueoption.