-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add codegen sample guide for Gaudi deployment #248
Conversation
Signed-off-by: alexsin368 <[email protected]>
4c644cc
to
3c94fab
Compare
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
Signed-off-by: alexsin368 <[email protected]>
b5d8d84
to
71182fb
Compare
This is a new document. Not sure how to address this issue in the Check Online Document Building test: make: *** [Makefile:65: html] Error 2 |
Don't worry about this. Just make sure the file is actually there. |
Signed-off-by: alexsin368 <[email protected]>
…ect-docs into codegen_doc Signed-off-by: alexsin368 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Actually if you make a small change like this:
and then create this file:
This should fix that issue 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please update the examples/index.rst
as mentioned in comments.
Signed-off-by: alexsin368 <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Signed-off-by: alexsin368 <[email protected]>
@tomlenth @NeoZhangJianyu please review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Targeting v1.1 release