-
Notifications
You must be signed in to change notification settings - Fork 84
added information regarding K&s install customization #42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Kubespray offers K&s cluster customization which needs to be desribed. Default use of instruction leads to failure during TASK [kubernetes/control-plane : Kubeadm | Initialize first master] which is caused by using port 6443 instead 8080.
@jpiaseck please address the DCO issue and minor merge conflict. |
BTW, when you use the online github.com editor, you need to manually add the |
- container manager | ||
- kube_apiserver_port | ||
- kube_pods_subnet | ||
- all K&s addons configurations, or even define to deploy cluster on hyperscaller like AWS or GCP. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am not Kubernetes expertise, but the "K&s" looks like a typo for me here. you meant k8s? the line 93 and 95 have same issues here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
DCO -- https://github.com/apps/dco
Basically, in your comment messages need a -s with your email matching up with your github ID.
"git commit -a -s -m "something"
You could also configure this in your .gitconfig
Then when you do git log in a repo you get information about who made the commit. eg: Signed-off-by: letonghan [email protected]
@jpiaseck sorry for the delay for a long time as team keep to refactor the code and doc. If possible, would you please resolve the conflicts or resubmit the PR based on latest version. thank you! |
Kubespray offers K&s cluster customization which needs to be desribed. Default use of instruction leads to failure during TASK [kubernetes/control-plane : Kubeadm | Initialize first master] which is caused by using port 6443 instead 8080.